Use the new re-entrant do-nothing script #6062

trexfeathers · 2024-07-18T16:53:04Z

🚀 Pull Request

Description

Just a draft so we can trial it in the upcoming release.

https://github.com/SciTools-incubator/nothing

need to set appropriate permissions for the new repo

Consult Iris pull request check list

Add any of the below labels to trigger actions on this PR:

benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

codecov · 2024-07-18T17:02:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (7bca716) to head (33f2cd7).
Report is 59 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6062   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          88       88           
  Lines       23315    23315           
  Branches     4338     4338           
=======================================
  Hits        20945    20945           
  Misses       1644     1644           
  Partials      726      726

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tools/release_do_nothing.py

pp-mo · 2024-09-12T11:49:20Z

Tested this in use + it was handy
But it would be nice if the "nothing" package allowed you to restart from latest stored.
I created a couple of issues to suggest improvements in the common code package : SciTools-incubator/nothing#1 SciTools-incubator/nothing#2

trexfeathers · 2024-09-12T13:05:45Z

Tested this in use + it was handy But it would be nice if the "nothing" package allowed you to restart from latest stored. I created a couple of issues to suggest improvements in the common code package : SciTools-incubator/nothing#1 SciTools-incubator/nothing#2

Thanks @pp-mo these are great suggestions! I don't consider them a blocker to this PR, which I know @HGWright is looking at today.

tools/release_do_nothing.py

Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>

tools/release_do_nothing.py

ESadek-MO

I think you're pretty much there. There are a few comments sitting on this PR, and I've added one of my own. I think once they're all done we merge this is, and if there's further issues we fix those when they arise.

tools/release_do_nothing.py

trexfeathers · 2024-11-04T10:40:33Z

Thanks @ESadek-MO!

* Use the new re-entrant do-nothing script. * Proper import error handling. * Always use git add. * More automation around CF standard names. * Missing bracket. * Less nebulous language. * Encourage copy-pasting from previous releases. * Clearer wording about release branches. * Clearer RTD versioning. * More precise installation tests. * Clearer rc branch naming. * Draw attention to deviation from conda-forge guidance. * Wait for CI to finish. * Include conda search command. * Comment on discussion. * Viva Engage. * Use a git command for recreating files. * Better SHA256 validation. * Add missing conda deactivate command. * Correct URL for watching conda-forge process. * Correct use of self.git_tag. * More guidance about when to change RC feedstock files. * Better advice for waiting for conda testing. * Raise correct message if `nothing` is not installed. Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com> * Line breaks in CF standard names instructions. Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com> * Don't use override-channels * Shout louder about NOT targeting the main branch. * More specificity in creating PRs, extra check for conda-forge RCs. * Corrected sha256 check. * What's New entry. --------- Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>

Use the new re-entrant do-nothing script.

044fdda

trexfeathers self-assigned this Jul 19, 2024

trexfeathers commented Aug 2, 2024

View reviewed changes

trexfeathers added 16 commits August 12, 2024 16:53

Proper import error handling.

7abb68e

Always use git add.

65f8294

More automation around CF standard names.

3ec6628

Missing bracket.

938f05f

Less nebulous language.

c0ac209

Encourage copy-pasting from previous releases.

7510b78

Clearer wording about release branches.

387c978

Clearer RTD versioning.

713662e

More precise installation tests.

61bf2a4

Clearer rc branch naming.

c2ef5b8

Draw attention to deviation from conda-forge guidance.

09b1191

Wait for CI to finish.

41c3e49

Include conda search command.

7047633

Comment on discussion.

76beb65

Viva Engage.

a010bd3

Use a git command for recreating files.

0c96810

trexfeathers commented Aug 13, 2024

View reviewed changes

tools/release_do_nothing.py Outdated Show resolved Hide resolved

HGWright reviewed Aug 13, 2024

View reviewed changes

tools/release_do_nothing.py Show resolved Hide resolved

trexfeathers commented Aug 13, 2024

View reviewed changes

tools/release_do_nothing.py Outdated Show resolved Hide resolved

trexfeathers commented Aug 13, 2024

View reviewed changes

tools/release_do_nothing.py Outdated Show resolved Hide resolved

trexfeathers commented Aug 13, 2024

View reviewed changes

tools/release_do_nothing.py Outdated Show resolved Hide resolved

trexfeathers added 5 commits August 14, 2024 11:39

Better SHA256 validation.

bc7f6bc

Add missing conda deactivate command.

0f8721b

Correct URL for watching conda-forge process.

78d0255

Correct use of self.git_tag.

94fa686

More guidance about when to change RC feedstock files.

25812b0

Better advice for waiting for conda testing.

7af5d22

trexfeathers marked this pull request as ready for review August 14, 2024 14:53

Merge branch 'main' into new_do_nothing

84818cf

trexfeathers assigned ESadek-MO Aug 15, 2024

trexfeathers assigned HGWright and unassigned trexfeathers and ESadek-MO Sep 11, 2024

ESadek-MO self-assigned this Oct 23, 2024

ESadek-MO reviewed Oct 28, 2024

View reviewed changes

tools/release_do_nothing.py Outdated Show resolved Hide resolved

ESadek-MO reviewed Oct 28, 2024

View reviewed changes

tools/release_do_nothing.py Outdated Show resolved Hide resolved

trexfeathers and others added 2 commits October 28, 2024 14:08

Raise correct message if nothing is not installed.

3f53941

Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>

Line breaks in CF standard names instructions.

5d65d6a

Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>

ESadek-MO reviewed Oct 28, 2024

View reviewed changes

tools/release_do_nothing.py Outdated Show resolved Hide resolved

trexfeathers commented Oct 29, 2024

View reviewed changes

tools/release_do_nothing.py Show resolved Hide resolved

trexfeathers commented Oct 29, 2024

View reviewed changes

tools/release_do_nothing.py Outdated Show resolved Hide resolved

Don't use override-channels

f446c9c

ESadek-MO requested changes Oct 30, 2024

View reviewed changes

tools/release_do_nothing.py Outdated Show resolved Hide resolved

trexfeathers added 5 commits November 1, 2024 13:37

Shout louder about NOT targeting the main branch.

4cf07a9

More specificity in creating PRs, extra check for conda-forge RCs.

8577b79

Corrected sha256 check.

3e6fd1f

Merge remote-tracking branch 'upstream/main' into new_do_nothing

f7021ea

What's New entry.

33f2cd7

ESadek-MO approved these changes Nov 4, 2024

View reviewed changes

ESadek-MO merged commit 5714ed6 into SciTools:main Nov 4, 2024
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the new re-entrant do-nothing script #6062

Use the new re-entrant do-nothing script #6062

trexfeathers commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

pp-mo commented Sep 12, 2024

trexfeathers commented Sep 12, 2024

ESadek-MO left a comment

trexfeathers commented Nov 4, 2024

Use the new re-entrant do-nothing script #6062

Use the new re-entrant do-nothing script #6062

Conversation

trexfeathers commented Jul 18, 2024 • edited Loading

🚀 Pull Request

Description

codecov bot commented Jul 18, 2024 • edited Loading

Codecov Report

pp-mo commented Sep 12, 2024

trexfeathers commented Sep 12, 2024

ESadek-MO left a comment

Choose a reason for hiding this comment

trexfeathers commented Nov 4, 2024

trexfeathers commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading