CF CoordSystems (replacement pull) #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Can't see the snippets for this pull request, can only see the code in the diffs view. |
|
Outstanding issues:
|
|
why can't this be merged automatically? |
|
Don't merge from master! Rebase instead. |
Merged
|
oops |
| raise ValueError("The source and grid cubes must contain a HorizontalCS.") | ||
| source_cs = source_cube.coord_system(iris.coord_systems.CoordSystem) | ||
| grid_cs = grid_cube.coord_system(iris.coord_systems.CoordSystem) | ||
| if source_cs==None != grid_cs==None: |
There was a problem hiding this comment.
Both occurrences of == should be is.
|
OK - let's separate out the curl issue. It still looks like it's broken to me so I'd like someone else (e.g. @pelson) to take a look. Increasing the radius should decrease the curl, and this should be countered by the increase in |
rhattersley
added a commit
that referenced
this pull request
Sep 11, 2012
CF-style CoordSystem classes
This was referenced Sep 11, 2012
|
@rhattersley , please also note the units are 1000 times smaller, here and here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull replaces #52, which had problems with the commit history.