Add support for plotting subclasses of cftime.datetime #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would love to use nc-time-axis in xarray. There was some discussion over the summer about possibly adding support for plotting subclasses of
cftime.datetime
(e.g.cftime.DatetimeNoLeap
) directly. This would make using it in xarray somewhat easier. This PR is an attempt to add that. In so doing, I've retained support for plottingnc_time_axis.CalendarDateTime
objects, so this should be backwards-compatible.Let me know if there is still interest in this. I'm happy to iterate on it if desired.
For example, with this PR one can now do something like this: