Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctrine/lexer deprecations #95

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix doctrine/lexer deprecations #95

merged 1 commit into from
Jan 29, 2024

Conversation

norkunas
Copy link
Contributor

No description provided.

@alexander-schranz alexander-schranz mentioned this pull request Jan 29, 2024
Closed
@alexander-schranz
Copy link

Would be great to have this soon be merged and released else as the package currently not define its requirement to doctrine/lexer would break as soon as doctrine/orm 2.18 is released as that allows doctrine/lexer 3. /cc @Hikariii :)

Hikariii
Hikariii approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@Hikariii Hikariii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much. This was not on my radar. Will try to improve deprecation handling and checking in the future.

@Hikariii Hikariii merged commit bf5f27e into ScientaNL:master Jan 29, 2024
@norkunas norkunas deleted the fix-lexer-deprecations branch January 29, 2024 15:54
@Hikariii Hikariii mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hikariii Hikariii Hikariii approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@norkunas @alexander-schranz @Hikariii @derrabus