-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.18.x: Lexer not longer implementing ArrayAccess #11192
Comments
Ah yes, that seems fair. In #11180 (comment), @derrabus was wondering why didn't allow |
@alexander-schranz actually, I'm not sure we should revert. I think the crash is happening here, correct: https://github.com/oroinc/doctrine-extensions/blob/2.0.3/src/Oro/ORM/Query/AST/Functions/String/GroupConcat.php#L46 ? The class in |
I did a PR on the oro extensions, oroinc/doctrine-extensions#96. But think I need to also increase the required version for orm and dbal as doctrine/lexer did not exist always on older orm versions. |
Same problem found for: martin-georgiev/postgresql-for-doctrine#177 and here alrey PR exists ScientaNL/DoctrineJsonFunctions#95 |
To clarify a bit further why we might have not allowed |
I think we can close this one as it is not an issue on the doctrine side as the other packages need to define there dependencies here deeper. |
BC Break Report
Summary
Theoro/doctrine-extensions
is using theDoctrine\ORM\Query\Lexer
, with adding support fordoctrine/lexer
version 3 in 2.18 of doctrine/orm theDoctrine\ORM\Query\Lexer
not longer implements the ArrayAccess which leads to an unexpected error.Update: its the
Token
class which is not longer implementing the ArrayAccess. Maybe we need to make sure that all doctrine extensions require the correct supported lexer version before we release 2.18.0. So no changes maybe require to fix this issue in orm package.Previous behavior
ArrayAccess was implemented byDoctrine\ORM\Query\Lexer
over thedoctrine/lexer:2
package.doctrine/lexer:2
was installed which Token implemented the ArrayAccess.Current behavior
ArrayAccess is not longer implemented which ends in:
How to reproduce
Using GroupConcat of oro/doctrine-extensions. As they never directly u se the
doctrine/lexer
namespace just thedoctrine/orm
namespace it is unexpected that in the minor jump the Orm/Lexer not longer shipped with ArrayAccess. So we maybe need to implement the ArrayAccess for thedoctrine/orm
Lexer and remove it then in doctrine/orm 3 to avoid this bc break.The text was updated successfully, but these errors were encountered: