Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doctrine/lexer 3 #11180

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Allow doctrine/lexer 3 #11180

merged 1 commit into from
Jan 22, 2024

Conversation

greg0ire
Copy link
Member

No description provided.

@greg0ire greg0ire marked this pull request as ready for review January 21, 2024 18:29
@derrabus
Copy link
Member

Why haven't we done this earlier? 🤔

@greg0ire
Copy link
Member Author

greg0ire commented Jan 22, 2024

I asked myself the same question, and I have no clear answer for now… but I think it will make it harder to upgrade to ORM 3.0 if we don't allow it, so it definitely seems logical. I think maybe at some point we had 1 || 2 and felt satisfied with it, when the goal should have been 2 || 3.

EDIT: rather, we couldn't have 1 || 2 || 3, so went with just 2 in #10329 as a backport of what was done in 3.0.x, and then forgot to add the || 3 in a follow-up PR / didn't realise it was possible.

@greg0ire greg0ire added this to the 2.18.0 milestone Jan 22, 2024
@greg0ire greg0ire merged commit 2d65bc2 into doctrine:2.18.x Jan 22, 2024
58 checks passed
@greg0ire greg0ire deleted the allow-lexer-3 branch January 22, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants