Drop doctrine/lexer 1 #10329
Merged
Drop doctrine/lexer 1 #10329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unsure if it isn't too soon to merge this PR into 2.x. We should watch the adoption of Lexer 2 a bit before we merge this change. Right now, Symfony's CI would be pinned to 2.14 if we merged this PR. |
|
Ok, I'm not in a hurry. |
|
At least egulias/EmailValidator#340 should be resolved first. That package is used by Symfony Mailer and Validator. |
greg0ire
force-pushed
the
drop-lexer-1-backport
branch
from
03cf0c6
to
ddb3f64
Compare
Merged
✅ Now, Symfony's CI is fully unblocked and uses Annotations 2 and Lexer 2 everywhere. ✌🏻 |
|
@derrabus feel free to rebase this, I tried resolving the conflict from my phone but couldn't. |
derrabus
force-pushed
the
drop-lexer-1-backport
branch
from
ddb3f64
to
603ab9a
Compare
SenseException
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #10309 , except I'm not migrating to an enum for obvious reasons.