Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): Explicit declaration of source(bucket name) of suggested manifests #10396

Closed
wants to merge 2 commits into from

Conversation

HUMORCE
Copy link
Member

@HUMORCE HUMORCE commented Feb 1, 2023

Relates to ScoopInstaller/Scoop#5131

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Your changes do not pass checks.

android-studio

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ani-cli

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

asciidocfx

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

axiom

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

capframex

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

castle-view-image

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ccextractor

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

crunchy-cli

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

electron-fiddle

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

fbflipper

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ffqueue

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

flameshot

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

flutter

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

fvim

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

git-aliases

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

goneovim

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

icecast

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

inno-setup

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ipscan

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

jellyfin

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

josm

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

klatexformula

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

kui

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

languagetool-java

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

lightbulb

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

linqpad

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

monokle

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

mpc-qt

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

mpc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

mpv-git

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

mpv

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

mqtt-spy

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

mucommander

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

ncmpc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

neovide

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

neovim-qt

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

netch

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

nvui

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

openrgb

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

openvpn

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

openwithplusplus

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

pass-winmenu-nogpg

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

pdd

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

pet

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

plex-desktop

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

posh-docker

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

qt-creator

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

qv2ray

  • Description
  • License
  • Hashes

rclone-browser

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

ripme

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

roslynpad

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

rssguard

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

screentogif

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

shadowsocksr-hmbsbige

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

spicetify-themes

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

stash

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

stoplight-studio

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

streamlink

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

superputty

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

testcentric

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

texmaker

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

tlaplus-toolbox

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

todolist

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

transgui

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ubports-installer

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

uivonim

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

vagrant-manager

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

waifu2x-snowshell

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

win-gpg-agent

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

wing-101

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

wox

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

xdman

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

xnconvert

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

yed

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@HUMORCE HUMORCE changed the title (chore): Clearly identify bucket of suggested manifest (chore): Explicit declaration of source(bucket name) of suggested manifests Feb 2, 2023
@HUMORCE HUMORCE marked this pull request as draft March 10, 2023 09:24
@jasongodev
Copy link
Contributor

What's the progress of this PR? Looks cool to me.

I believe there must be a mention of this in the Scoop Documentation. Something like "Packages in buckets officially supported by Scoop will have their dependencies fetched from the respective official buckets as well. App manifest authors need to specify the bucket if they are using unofficial buckets."

@HUMORCE HUMORCE closed this Apr 23, 2023
@HUMORCE
Copy link
Member Author

HUMORCE commented Apr 23, 2023

What's the progress of this PR? Looks cool to me.

Done now

I believe there must be a mention of this in the Scoop Documentation. Something like "Packages in buckets officially supported by Scoop will have their dependencies fetched from the respective official buckets as well. App manifest authors need to specify the bucket if they are using unofficial buckets."

I prefer to state explicitly, include main bucket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants