Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bucket): Make official buckets higher priority #5398

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Feb 20, 2023

Description

Sort buckets and make official buckets first, with order in https://github.com/ScoopInstaller/Scoop/blob/master/buckets.json

Change the function Get-LocalBucket() in buckets.ps1 that should affect all commands related to unknown bucket in app name. (i.e., app not bucket/app)

Motivation and Context

How Has This Been Tested?

Before:
image

After:
image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@HUMORCE
Copy link
Member

HUMORCE commented Feb 22, 2023

Sorry, I was in a car crash. I will test and feedback next week.

@niheaven niheaven changed the title feat(buckets): Make official buckets higher priority feat(bucket): Make official buckets higher priority Mar 10, 2023
@niheaven
Copy link
Member Author

Ping @HUMORCE

@HUMORCE
Copy link
Member

HUMORCE commented Mar 10, 2023

lgtm, I will update them when im free: ScoopInstaller/Versions#973 ScoopInstaller/Extras#10396 ScoopInstaller/Main#4409

@niheaven niheaven merged commit 559c6f9 into develop Mar 10, 2023
@niheaven niheaven deleted the sort-buckets branch March 10, 2023 09:24
@HUMORCE
Copy link
Member

HUMORCE commented Mar 14, 2023

But I don't think this PR can be closed #5131.

@niheaven
Copy link
Member Author

Hmm, partially solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants