Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter: Update to version 1.12.13-hotfix.7 #3489

Merged
merged 7 commits into from
Jan 30, 2020
Merged

flutter: Update to version 1.12.13-hotfix.7 #3489

merged 7 commits into from
Jan 30, 2020

Conversation

sinloss
Copy link
Contributor

@sinloss sinloss commented Jan 14, 2020 •
edited by Ash258
Loading

As the flutter officially used + instead of - to concatenate hotfix in their version string since 2019/7/9 or before, the scoop version has stuck at 1.5.4-hotfix.2 yet the real-world version has already been advanced to 1.12.13+hotfix.5.

So here is this PR.

@sinloss
flutter: fix checkver regex
136baf3 
As the flutter official site used `+` instead of `-` to concatenate `hotfix` in their version string since *2019/7/9* or before, the scoop version has stuck at `1.5.4-hotfix.2` yet the real-world version has already advanced to `v1.12.13+hotfix.5`.

So here is this PR.
@sinloss sinloss mentioned this pull request Jan 14, 2020
Closed
@linsui
Copy link
Contributor

linsui commented Jan 14, 2020 •
edited
Loading

dulplicate of #3113 #2770

@sinloss
Copy link
Contributor Author

sinloss commented Jan 14, 2020

Close this because of duplication

@sinloss sinloss closed this Jan 14, 2020
@sinloss sinloss deleted the patch-1 branch January 14, 2020 06:55
@sinloss sinloss restored the patch-1 branch January 29, 2020 01:11
@sinloss sinloss reopened this Jan 29, 2020
@sinloss
Change the way it extracts the hash
35e0593 
This approach avoids the controversial character "+" so that it works just fine
@sinloss
Copy link
Contributor Author

sinloss commented Jan 29, 2020 •
edited
Loading

Reopen this PR as the other approaches did not really fix the whole issue straightforwardly. Thus I introduce this approach I used locally just to make the flutter right immediately (it has been too long that the scoop install flutter installs the very old release). This PR introduced an approach of separately extracting version and build number and forging a scoop friendly version string to avoid the controversial character + mentioned in ScoopInstaller/Scoop#3613

@Ash258 Ash258 changed the title flutter: fix checkver regex flutter: Update to version 1.12.13-hotfix.7 Jan 30, 2020
@sinloss sinloss requested a review from brandon93s January 30, 2020 09:35
@Ash258 Ash258 merged commit 82a8a2e into ScoopInstaller:master Jan 30, 2020
@sinloss sinloss deleted the patch-1 branch January 30, 2020 23:49
@sinloss sinloss mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon93s brandon93s Awaiting requested review from brandon93s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The exact "+" sign would be decoded as a space update flutter 1.9 how to update flutter bucket
3 participants
@sinloss @linsui @Ash258