Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version pattern to support latest flutter v1.7.8+hotfix.4 #3613

Closed
wants to merge 2 commits into from
Closed

Update version pattern to support latest flutter v1.7.8+hotfix.4 #3613

wants to merge 2 commits into from

Conversation

hanabi1224
Copy link

No description provided.

@hanabi1224 hanabi1224 changed the title update version pattern to latest flutter v1.7.8+hotfix.4 Update version pattern to support latest flutter v1.7.8+hotfix.4 Aug 28, 2019
Ash258
Ash258 suggested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Characters in classses do not need to be escaped.

schema.json Outdated Show resolved Hide resolved
@hanabi1224
Update schema.json
0207d00 
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
@hanabi1224
Copy link
Author

@Ash258 Fixed, plz let me know if there's anything else outstanding

@Ash258
Copy link
Contributor

Ash258 commented Aug 31, 2019

This is working and good, but I cannot approve this PR as I do not know initial reason why there are some characters forbidden in version property.

@hanabi1224
Copy link
Author

@Ash258 Thx, is there anything I can do to move this forward?

@hanabi1224
Copy link
Author

kindly ping

@niheaven niheaven mentioned this pull request Sep 20, 2019
Merged
@hanabi1224
Copy link
Author

Kindly ping

@niheaven
Copy link
Member

It is very strang for their usage of plus sign '+', and please wait for new version comparison function.

@hanabi1224
Copy link
Author

@niheaven They intentionally change - to +. explanation here. https://github.com/flutter/flutter/wiki/Release-process#applying-emergency-fixes

@niheaven niheaven mentioned this pull request Oct 29, 2019
Merged
@linsui linsui mentioned this pull request Nov 4, 2019
Closed
@linsui linsui mentioned this pull request Nov 20, 2019
Closed
@niheaven niheaven mentioned this pull request Nov 28, 2019
Closed
@Nebulavenus Nebulavenus mentioned this pull request Dec 6, 2019
Closed
@sinloss sinloss mentioned this pull request Jan 29, 2020
Merged
@Ash258 Ash258 mentioned this pull request Aug 21, 2020
Open
21 tasks
@niheaven
Copy link
Member

Fixed in #4504

@niheaven niheaven closed this Nov 18, 2021
@hanabi1224 hanabi1224 deleted the flutter_version branch November 18, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linsui linsui linsui left review comments

@Ash258 Ash258 Ash258 requested changes

@niheaven niheaven niheaven left review comments

@chawyehsu chawyehsu chawyehsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanabi1224 @Ash258 @niheaven @chawyehsu @linsui