Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter: Move from extras #366

Closed
wants to merge 4 commits into from
Closed

flutter: Move from extras #366

wants to merge 4 commits into from

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Aug 17, 2019

],
"depends": [
"android-sdk",
"java/adopt8-hotspot"
Copy link
Contributor

@Ash258 Ash258 Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is special requirement to have this exact version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter does not depend on java, but android sdk depends on java.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not manually mark conversation as resolved when all users who was part of conversation did not read it. Because when you comment on discussion other user will get notification for it. And when you push to repository notification will be replaced with this push.

Which make other user to go through all collapsed conversations and uncollapsed them and see them one by one if there is new message. Instead of seeing it on PR page directly.

bucket/flutter.json Outdated Show resolved Hide resolved
bucket/flutter.json Outdated Show resolved Hide resolved


# Gets the installed packages list from sdkmanager
function get-installed {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script could be rewritten to follow core format. But as it is work it is OK for moving.

linsui and others added 3 commits August 18, 2019 15:11
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
@BKBuEGmbH
Copy link

BKBuEGmbH commented Nov 20, 2019

Flutter is not upgrade to new versions right now. It seems to be blocked by this move. Ash258 you wrote that it is OK for moving, but this PR is blocked. What needs to be done to get this PR and the one in extras merged?

Edit:
Sorry Ash258, I did not want to upset you with this question.

@linsui
Copy link
Contributor Author

linsui commented Nov 20, 2019

ScoopInstaller/Scoop#3613 and ScoopInstaller/Scoop#3721 block fultter get update.

@chawyehsu chawyehsu added the upstream Waiting for upstream (the developers of the software) to fix the problem label Jan 3, 2020
@linsui linsui closed this Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Waiting for upstream (the developers of the software) to fix the problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants