-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flutter: Move from extras #366
Conversation
bucket/flutter.json
Outdated
], | ||
"depends": [ | ||
"android-sdk", | ||
"java/adopt8-hotspot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is special requirement to have this exact version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flutter does not depend on java, but android sdk depends on java.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not manually mark conversation as resolved when all users who was part of conversation did not read it. Because when you comment on discussion other user will get notification for it. And when you push to repository notification will be replaced with this push.
Which make other user to go through all collapsed conversations and uncollapsed them and see them one by one if there is new message. Instead of seeing it on PR page directly.
|
||
|
||
# Gets the installed packages list from sdkmanager | ||
function get-installed { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script could be rewritten to follow core format. But as it is work it is OK for moving.
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
Flutter is not upgrade to new versions right now. It seems to be blocked by this move. Ash258 you wrote that it is OK for moving, but this PR is blocked. What needs to be done to get this PR and the one in extras merged? Edit: |
ScoopInstaller/Scoop#3613 and ScoopInstaller/Scoop#3721 block fultter get update. |
ScoopInstaller/Extras#2685