fix(install-env): Apply env immediately by SendMessageTimeout
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix it in Scoop Core too? |
niheaven
approved these changes
Apr 7, 2023
This was
linked to
issues
Apr 7, 2023
chawyehsu
reviewed
Apr 10, 2023
install.ps1
Outdated
| @@ -401,6 +425,7 @@ function Write-Env { | |||
| [Microsoft.Win32.RegistryValueKind]::String | |||
| } | |||
| $EnvRegisterKey.SetValue($name, $val, $RegistryValueKind) | |||
| Publish-Env | |||
There was a problem hiding this comment.
Should this be placed to two lines below? I suppose that DeleteValue is also an action involving env modification.
There was a problem hiding this comment.
I think it should not be a big problem not to publish after deletion, but it will not be wrong if it is applied.
install.ps1
Outdated
Comment on lines
389
to
390
| $HWND_BROADCAST = [IntPtr] 0xffff; | ||
| $WM_SETTINGCHANGE = 0x1a; |
There was a problem hiding this comment.
Suggested change
| $HWND_BROADCAST = [IntPtr] 0xffff; | |
| $WM_SETTINGCHANGE = 0x1a; | |
| $HWND_BROADCAST = [IntPtr] 0xffff | |
| $WM_SETTINGCHANGE = 0x1a |
chawyehsu
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem mentioned in #48, #46, #45 mainly casued by #44.
Thanks to @chawyehsu and @r15ch13 for the information.
The information mentioned in PowerShell/PowerShell#16989#issuecomment-1364615686 is very useful, especially the last link.
Add directory to Environment PATH variable shows a method to apply env immediately, almost the same code as used in chocolatey/choco Fix: Env var changes may require reboot.
I tested the new code in several virtual machines. The env can be updated normally outside the executing process. And because the installation script will get a new env for the current session, there is no problem in using it in the current session.
However, there is no way to get it to work when using in a Windows Terminal new tab, like chawyehsu said. But restarting a Windows Terminal can solve it.