Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(env): Apply env immediately by SendMessageTimeout #5452

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

WHYBBE
Copy link
Contributor

@WHYBBE WHYBBE commented Apr 1, 2023

Fix the problem caused by the merge of #5395, mentioned in 5424#issuecomment-1479734238, similar to ScoopInstaller/Install#49.

Use SendMessageTimeout in user32 to update the env in explorer.exe, and then the new env will be used in new process of powershell/cmd.

I have tested it in some cases and it works fine. I can't guarantee that all situations will be known to me. For example, a known issue is that if you use Windows Terminal, updating env in one tab does not update env in another tab of the same window, as mentioned in microsoft/terminal#14999.

@niheaven
Copy link
Member

niheaven commented Apr 6, 2023

For example, a known issue is that if you use Windows Terminal, updating env in one tab does not update env in another tab of the same window, as mentioned in microsoft/terminal#14999.

It seems to be fixed.

@niheaven niheaven merged commit 52059ca into ScoopInstaller:develop Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants