fix(env): Avoid automatic expansion of %% in env

[WHYBBE]

Description

For example, the following command is used to obtain system environment variables.

(Get-Item -Path "HKLM:\SYSTEM\CurrentControlSet\Control\Session Manager\Environment").GetValue(
    "Path",
    "",
    [Microsoft.Win32.RegistryValueOptions]::DoNotExpandEnvironmentNames)

The string obtained by it will not replace the %%.

Motivation and Context

Use the Registry to get the unexpanded environment variable string inspired by PowerShell/PowerShell#17518.
Fixes #5394
Related to #1813

How Has This Been Tested?

Checklist:

• I have read the Contributing Guide.
• I have ensured that I am targeting the develop branch.
• I have updated the documentation accordingly.
• I have updated the tests accordingly.
• I have added an entry in the CHANGELOG.

[r15ch13]

Probably fixes #5059 and with this implemented we should look into using dedicated %SCOOP_*% variables 😄

It should also be fixed in https://github.com/ScoopInstaller/Install as well

[WHYBBE]

Probably fixes #5059 and with this implemented we should look into using dedicated %SCOOP_*% variables 😄

It should also be fixed in https://github.com/ScoopInstaller/Install as well

Thank you for pointing out the related issue for me. I haven't found it after searching for a long time, so I specially raised a new issue.

I don't know what other unrelated functions my modification will affect. Perhaps more detailed testing is needed before it can be applied to ScoopInstaller/Install or used to implement %SCOOP_*%.

[rashil2000]

LGTM!

Please update the changelog.

[rashil2000]

So we need this change in the Installer as well - https://github.com/ScoopInstaller/Install

Similar to Get-Env, we can create a function Set-Env and use it on https://github.com/ScoopInstaller/Install/blob/c99c2f1d53cf699d1a02af1d5ad0ec897c9b6120/install.ps1#L390

[WHYBBE]

So we need this change in the Installer as well - https://github.com/ScoopInstaller/Install

Similar to Get-Env, we can create a function Set-Env and use it on https://github.com/ScoopInstaller/Install/blob/c99c2f1d53cf699d1a02af1d5ad0ec897c9b6120/install.ps1#L390

Modified in ScoopInstaller/Install#44

[r15ch13]

If $val is $null then the variable should be removed.
Steps to reproduce:

• scoop install coder
• scoop uninstall coder

function env($name, $global, $val = '__get') {
    $RegisterKey = if ($global) {
        Get-Item -Path 'HKLM:\SYSTEM\CurrentControlSet\Control\Session Manager'
    } else {
        Get-Item -Path 'HKCU:'
    }

    if ($val -eq '__get') {
        $EnvRegisterKey = $RegisterKey.OpenSubKey('Environment')
        $RegistryValueOption = [Microsoft.Win32.RegistryValueOptions]::DoNotExpandEnvironmentNames
        $EnvRegisterKey.GetValue($name, $null, $RegistryValueOption)
    } else {
        $EnvRegisterKey = $RegisterKey.OpenSubKey('Environment', $true)
        if($null -eq $val) {
            $EnvRegisterKey.DeleteValue($name)
        } else {
            if($val.Contains('%')) {
                $EnvRegisterKey.SetValue($name, $val, [Microsoft.Win32.RegistryValueKind]::ExpandString)
            } else {
                $EnvRegisterKey.SetValue($name, $val, [Microsoft.Win32.RegistryValueKind]::String)
            }
        }
    }
}