nmap: Extract and install npcap

[linsui]

Now npcap will be installed in nmap directory. Due to unknown reasons, uninstall will fail and need to uninstall manaully.

Can be merged after ScoopInstaller/Scoop#3547

[linsui]

The uninstall need privileges. nmap uninstaller won't uninstall npcap so there is no problem before. By the way, could anyone have a look at ScoopInstaller/Scoop#3567 ? With sudo it works. Will it be fixed or we need to use sudo instead?

[rasa]

In my opinion, if an app needs elevation to install/uninstall, it should depend on sudo, and then use it to install the app. See https://github.com/lukesampson/scoop-extras/blob/e73c63bfbe3f369a126c4c74fd9baf8e7ff08281/bucket/pritunl-client.json#L16 for an example.

[niheaven]

See ScoopInstaller/Extras#2464, you could use -RunAs.

[linsui]

@rasa @niheaven Thanks. What's the suggested way?

[niheaven]

I suggest -RunAs that needn't depends: sudo, and please check if works.

But this param was fixed in ScoopInstaller/Scoop#3547 and not be merged into scoop/master yet, so you might halt your PR and wait for merging (has been merged into develop)

[linsui]

@niheaven It works well, thanks. If it can be write as

    {
        "file": "Uninstall.exe",
        "args": "/S",
        "admin": true
    }

it would be better 😂

[niheaven]

Wow, right, I'll do this works in ScoopInstaller/Scoop#3502

[linsui]

Please review.

[Ash258]

I do not think that RunAs usage is good for Main bucket. Will there be UAC popup? Will it fail if no administrator terminal / sudo is not used?

[Ash258]

Unescaped dir after /D

Suggested change

	"script": "Invoke-ExternalCommand -FilePath \"$dir\\npcap.exe\" -ArgumentList \"/S /D=$dir\\npcap\" -RunAs | Out-Null"
	"script": "Invoke-ExternalCommand -FilePath \"$dir\\npcap.exe\" -ArgumentList \"/S /D=\"\"$dir\\npcap\"\"\" -RunAs | Out-Null"

Try installation with single quotes

[linsui]

It doesn't work with quotes.

[rasa]

nsis requires /D$dir. It breaks with quotes. See ScoopInstaller/Scoop#2003

[linsui]

@Ash258 RunAs shows a UAC pop.
Npcap need privelege to install so if maintainers want to keep main bucket non-privilege we can move it to extras or non-portable. It seems that the only criteria which is executed strictly now is non-GUI...