Fix #4000, handle arch-specific env_add_path #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash258
previously requested changes
Jun 8, 2020
There was a problem hiding this comment.
- Fix
env_set(env_rm) too (https://github.com/lukesampson/scoop/blob/96de9c14bb483f9278e4b0a9e22b1923ee752901/lib/install.ps1#L952-L981)
In this codebase it has to be fixed on multiple places.
- bin\uninstall
- libexec\scoop-update
- libexec\scoop-uninstall
Sure, I'll see to it. |
|
@Ash258 And you are working on the |
|
My changes will not go here. |
Mind me asking why? |
21 tasks
Ash258
referenced
this pull request
in Ash258/Scoop-Core
Aug 27, 2020
fix(tests): Force pester v4 (ScoopInstaller#4040)
Merge upstream commits
|
/verify |
|
kindly ping |
niheaven
approved these changes
Oct 29, 2021
rashil2000
approved these changes
Nov 1, 2021
|
@rashil2000 You should merge everything into |
|
Will keep that in mind. What about PR's that already have |
|
Retarget them, by using |
|
Sure, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4000