Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scoop-prefix): remove unused imports and functions. Load when required #4493

Closed
wants to merge 21 commits into from
Closed

feat(scoop-prefix): remove unused imports and functions. Load when required #4493

wants to merge 21 commits into from

Conversation

pratikpc
Copy link
Contributor

@pratikpc pratikpc commented Nov 3, 2021

Unused imports removed:-

  1. manifest.ps1
  2. buckets.ps1

Unused function removed:-

  1. reset_aliases:- We do not use aliases here.

Load when required

  1. help needs to be loaded only when app is not specified
  2. core needs to be loaded only when app is specified

Gains:-

  1. Improved speed.

sinloss and others added 21 commits June 8, 2020 10:16
@sinloss
Fix #4000, handle arch-specific env_add_path
3188115
@sinloss
Apply the suggestions from @Ash258
91ea657
@sinloss
scoop-info: Handle arch-specific envs
6659c55
@sinloss
Re-trigger tests
5e81d49
@sinloss
Annihilate the trailing whitespace
c845376
@sinloss
Merge pull request #1 from lukesampson/master
8ecdb7c 
fix(tests): Force pester v4 (#4040)
@sinloss
Merge pull request #2 from lukesampson/master
dc7df61 
Merge upstream commits
@sinloss
Fix the eol error complained by the tests
63a2658
@mehmetumit
Fixed trailing whitespace issue (#4307)
3d67b7d
@FriendlyNeighborhoodShane
reset: skip when app instance is running (#4359)
0920050 
The issue is the same as for #2952, workaround until the proper
solution is implemented. The code is also directly copied from there.

Fixes #4310
@rasa
chore: move extras bucket to @ScoopInstaller
3e9a4d4
@rasa
chore: Update extras bucket url in readme
f1a46e1
@rasa
chore: s/lukesampson/ScoopInstaller in readme
4f5acd7
@rasa
chore: s/lukesamson/ScoopInstaller in install.ps1
5226f26
@rashil2000
chore: capitalize to prevent redirect (#4483)
b174775
@lediur
Restrict url() scope to avoid conflict with global aliases
818162f
@rashil2000
Change url() scope to avoid conflict with global aliases (#4342)
35b2a42 
(e.g. Pansies)
@rashil2000
Merge pull request #4013 from sinloss/patch-1
6c340cb 
Fix #4000, handle arch-specific env_add_path
@Lockszmith-GH
Fix incompatible with Pansies url alias
1e90310 
Fixes #4185
A continuation of #4342
@niheaven
fix(core): use script:url instead of url (#4492)
bae0be9
@pratikpc
feat(scoop-prefix): remove unused imports and functions. Load when re…
e50d00f 
…quired

Unused imports removed:-
1. manifest.ps1
2. buckets.ps1

Unused function removed:-
1. reset_aliases:- We do not use aliases here.

Load when required
1. help needs to be loaded only when app is not specified
2. core needs to be loaded only when app is specified

Gains:-
1. Improved speed.
@pratikpc pratikpc mentioned this pull request Nov 3, 2021
Merged
@rashil2000
Copy link
Member

Retarget to develop branch. Master is for release.

@pratikpc
Copy link
Contributor Author

pratikpc commented Nov 3, 2021 •
edited
Loading

@rashil2000 are you sure?

Develop is behind master. It's 2nd most recent commit is from Oct 2020.

It's most recent commit from a few days back, which was from a PR opened in 2019.

To me something like this looks a bit weird.

Edit:- If this is the case, we should at least rebase develop on top of master. And stop new commits to master except via a split from develop.

@rashil2000
Copy link
Member

@niheaven would be able to suggest more on this.

@niheaven
Copy link
Member

niheaven commented Nov 4, 2021

@pratikpc Except for #4013 #4342 #4492, other merged PRs in master are only for text works. The recent commit (#3518) in develop is on the main develop line of scoop itself.

There are many feathers under development and they all should be committed into develop and tested by advanced users (incl. maintainers), only critical hotfixes that may affect normal users should be merged directly into master and synchronized to develop.

These commits that ahead develop now could be merged into develop after new commits in master and develop are all carefully tested, and then we can sync the branches and merge new PRs into develop and test them again.

@pratikpc pratikpc changed the base branch from master to develop November 4, 2021 11:52
@pratikpc pratikpc closed this Nov 4, 2021
@pratikpc pratikpc deleted the scoop-prefix-remove-unused-import-function-manifests branch November 4, 2021 11:52
@pratikpc
Copy link
Contributor Author

pratikpc commented Nov 4, 2021 •
edited
Loading

That makes sense.

Although we really should first rebase develop on master so that we may not end up with future conflicts.

Also created a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niheaven niheaven Awaiting requested review from niheaven

@Valinor Valinor Awaiting requested review from Valinor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@pratikpc @rashil2000 @niheaven @sinloss @mehmetumit @FriendlyNeighborhoodShane @rasa @lediur @Lockszmith-GH