Implemented support for FromQueryResult to work with generics
#1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't find tests for macros, so added them in a new file, let me know if there is a better way |
|
It seems that failed check is not because of this pr |
|
Yes, I think master has been fixed now. |
|
Thank you for the contribution! It looks good at first glance, but I would like to take a closer look later. |
|
Hey, any updates? |
tyt2y3
approved these changes
Apr 11, 2023
tyt2y3
pushed a commit
that referenced
this pull request
Apr 11, 2023
This was referenced Apr 20, 2023
🎉 Released In 0.12.1 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
FromQueryResultto work with generics