Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FromQueryResult proc_macro no longer add TryGetable trait bound to generic types #1603

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Apr 20, 2023

PR Info

Changes

  • FromQueryResult proc_macro no longer add TryGetable trait bound to generic types

@billy1624 billy1624 self-assigned this Apr 20, 2023
@billy1624 billy1624 marked this pull request as ready for review April 21, 2023 10:49
@billy1624 billy1624 requested a review from tyt2y3 April 21, 2023 10:50
@billy1624 billy1624 force-pushed the from-query-result-proc-macro-fix branch from 52b0f43 to 35ad102 Compare April 23, 2023 04:29
@tyt2y3
Copy link
Member

tyt2y3 commented Apr 24, 2023

Since the feature has never been released, please merge the two PR into one changelog

@billy1624 billy1624 merged commit b2d78d4 into master Apr 24, 2023
@billy1624 billy1624 deleted the from-query-result-proc-macro-fix branch April 24, 2023 03:34
@billy1624
Copy link
Member Author

Since the feature has never been released, please merge the two PR into one changelog

Got it :)

billy1624 added a commit that referenced this pull request Apr 24, 2023
…o generic types (#1603)

* `FromQueryResult` proc_macro no longer add `TryGetable` trait bound to generic types

* clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derive macro FromQueryResult generic bound not always correct
2 participants