Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues-383 Improve sea-query-binder #416

Merged
merged 7 commits into from
Sep 3, 2022
Merged

issues-383 Improve sea-query-binder #416

merged 7 commits into from
Sep 3, 2022

Conversation

ikrivosheev
Copy link
Member

@ikrivosheev ikrivosheev commented Aug 12, 2022 •
edited
Loading

PR Info

Adds

  • Add sqlx runtime features
  • Split sea-query-binder and sea-query to different workspace
  • Move examples to another workspace
  • Rewrite CI

@ikrivosheev ikrivosheev mentioned this pull request Aug 12, 2022
Merged
@ikrivosheev
Copy link
Member Author

@billy1624 @tyt2y3 if these changes are ok, I can fix CI.

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 18, 2022 •
edited
Loading

Yes they are OK. That'd be appreciated

@ikrivosheev ikrivosheev force-pushed the feature/issues-383_improve_binder branch from 2c703df to a057563 Compare August 20, 2022 10:29
@ikrivosheev
Copy link
Member Author

@tyt2y3 @billy1624 hello! Done!

This was referenced Aug 20, 2022
Merged
Merged
Closed
billy1624
billy1624 reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @ikrivosheev

Some comments on the CI #383 (comment)

@ikrivosheev
Copy link
Member Author

@billy1624 hello!

@ikrivosheev ikrivosheev requested a review from billy1624 August 25, 2022 10:24
billy1624
billy1624 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @ikrivosheev The CI looks good!

@tyt2y3 tyt2y3 merged commit 5367723 into SeaQL:master Sep 3, 2022
@tyt2y3
Copy link
Member

tyt2y3 commented Sep 3, 2022 •
edited
Loading

Thank you all

@ikrivosheev ikrivosheev deleted the feature/issues-383_improve_binder branch September 3, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@ikrivosheev ikrivosheev

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate / remove driver in favour of binder
3 participants
@ikrivosheev @tyt2y3 @billy1624