Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues-383 Create new crate for rusqlite #422

Merged
merged 5 commits into from
Sep 4, 2022

Conversation

ikrivosheev
Copy link
Member

PR Info

Adds

  • Add new crate like sea-query-binder for rusqlite.

Continue work on: #388

@ikrivosheev
Copy link
Member Author

@tyt2y3 @billy1624 for me looks better naming: sea-query-sqlx, sea-query-rusqlite. Name is shorter. Explicitly says to which driver this binding is

@billy1624
Copy link
Member

billy1624 commented Aug 26, 2022

@tyt2y3 @billy1624 for me looks better naming: sea-query-sqlx, sea-query-rusqlite. Name is shorter. Explicitly says to which driver this binding is

I agree. But the problem is that should we rename sea-query-binder to sea-query-slqx? And, how can we rename it (since it has been published to crates.io)?

I guess we could add a deprecated message at sea-query-binder/lib.rs?

#![deprecated(
    since = "0.1.0",
    note="The `sea-query-binder` crate has been renamed to `sea-query-sqlx`. Please update your dependency accordingly"
)]

Basically, we publish sea-query-sqlx on crates.io and no longer publish newer version under the name of sea-query-binder.

Ideas? @tyt2y3

@ikrivosheev
Copy link
Member Author

@tyt2y3 @billy1624 for me looks better naming: sea-query-sqlx, sea-query-rusqlite. Name is shorter. Explicitly says to which driver this binding is

I agree. But the problem is that should we rename sea-query-binder to sea-query-slqx? And, how can we rename it (since it has been published to crates.io)?

I guess we could add a deprecated message at sea-query-binder/lib.rs?

#![deprecated(
    since = "0.1.0",
    note="The `sea-query-binder` crate has been renamed to `sea-query-sqlx`. Please update your dependency accordingly"
)]

Basically, we publish sea-query-sqlx on crates.io and no longer publish newer version under the name of sea-query-binder.

Ideas? @tyt2y3

I can copy-paste sea-query-binder with new name: sea-query-sqlx, add deprecated warning in sea-query-binder and after some time we can remove the folder.

@ikrivosheev ikrivosheev force-pushed the feature/issues-383_rusqlite_v2 branch from 2211b86 to 5d54d5d Compare September 3, 2022 15:20
@ikrivosheev ikrivosheev force-pushed the feature/issues-383_rusqlite_v2 branch from 5d54d5d to 0ac0899 Compare September 3, 2022 15:25
@ikrivosheev
Copy link
Member Author

@tyt2y3 I fixed all merge conflicts.

@ikrivosheev ikrivosheev force-pushed the feature/issues-383_rusqlite_v2 branch from 4190c89 to 098f664 Compare September 3, 2022 15:38
@tyt2y3 tyt2y3 merged commit bb966a8 into SeaQL:master Sep 4, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-383_rusqlite_v2 branch September 4, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deprecate / remove driver in favour of binder
3 participants