-
Notifications
You must be signed in to change notification settings - Fork 142
CORTX-33586: ctgdump is crashing after new btree merge #1974
Conversation
Issue: - ctg_open() is responsible for allocating tree pointer and opening the btree. This was missing before accessing the catalogue tree in the ctgdump(). Fix: - Added ctg_open() call before accessing tree pointer. - Added m0_btree_close() to close tree in ctg_fini(). Signed-off-by: Kanchan Chaudhari <kanchan.chaudhari@seagate.com>
Tested patch with s3ios and 1N deployment with Custom Build #7171, IOs are working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This utility is an offline tool. The following test must be run and verified: It has not been added to ST list. Maybe it's time to add it into the list now. |
Please apply the following patch, and include this patch into your PR.
You will see something like this:
(Please ignore the panic there. It will be fixed in #1976) |
Signed-off-by: Kanchan Chaudhari <kanchan.chaudhari@seagate.com>
In reference to #1974 (comment), we will take this task as a part of separate ticket. CC: @huanghua78 |
Signed-off-by: Kanchan Chaudhari <kanchan.chaudhari@seagate.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Jenkins PR Run Result: https://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Motr/1484/ |
Issue:
opening the btree. This was missing before accessing the
catalogue tree in the ctgdump().
Fix:
Signed-off-by: Kanchan Chaudhari kanchan.chaudhari@seagate.com
Problem Statement
Design
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author