Do rms_resource_free() in rso_prepare_to_stop() #1976
Conversation
huanghua78
requested review from
mehjoshi,
madhavemuri,
nikitadanilov,
yeshpal-jain-seagate,
andriytk,
siningwuseagate,
vidyadhar-pinglikar,
shashank-parulekar,
nkommuri,
sg-shankar,
ivan-alekhin,
sergey-shilov and
rkothiya
as code owners
huanghua78
force-pushed
the
rmsvc_prepare_to_stop
branch
from
e4dad23 to
39822e3
Compare
|
I am sorry, but why is the lnet test included in the UT? |
From the log, I can see Lustre/Lnet is still used to build the lnet transport. |
Please see the below comments. Based on above inputs, even if lnet is not the default transport, the lnet UT is enabled if the lustre rpms are installed and m0tr.ko is available. |
Jenkins CI Result : Motr#1463Motr Test Summary
CppCheck SummaryCppcheck: No new warnings found 👍 |
|
Hello @andriytk , can you please help check this failure? https://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Motr/1463//testReport/junit/01motr-single-node/00userspace-tests I verified this UT failure locally. |
And this is the fix: @andriytk , please verify. |
|
Thanks @huanghua78! The fix for the UT looks good. |
In commit 3af2fc7, we do reverse session cleanup in prepare_to_stop(). So, we must also do rms_resource_free() in rso_prepare_to_stop(). This patch fixes the rm-ut:rmvsv UT failure: Thread 29 (Thread 0x7f77553f4700 (LWP 1763408)): 0 0x00007f77adb9ada8 in nanosleep () from /lib64/libc.so.6 1 0x00007f77adb9acae in sleep () from /lib64/libc.so.6 2 0x00007f77afc34af2 in m0_debugger_invoke () at lib/user_space/uassert.c:144 3 0x00007f77afc34c04 in m0_arch_panic (c=c@entry=0x7f77b00fa700 <signal_panic>, ap=ap@entry=0x7f77553f2538) at lib/user_space/uassert.c:129 4 0x00007f77afc22ba7 in m0_panic (ctx=ctx@entry=0x7f77b00fa700 <signal_panic>) at lib/assert.c:52 5 0x00007f77afc34c48 in sigsegv (sig=11) at lib/user_space/ucookie.c:52 6 <signal handler called> 7 m0_rpc_conn_is_snd (conn=0x5f5f5f5f5f5f5f5f) at rpc/conn.c:282 8 0x00007f77afcbe0a1 in m0_rpc_post (item=item@entry=0x7f773d820130) at /home/520428/work/cortx-motr/rpc/rpc_internal.h:97 9 0x00007f77b136c498 in m0_rm_outgoing_send (outgoing=outgoing@entry=0x7f773d820050) at /home/520428/work/cortx-motr/rm/rm_fops.c:310 10 0x00007f77b136c7dd in outgoing_queue (other=0x7f77a419ce50, in=0x7f773f0e63d0, outreq=0x7f773d820050, owner=0x7f77a41ca0d0, otype=M0_ROT_REVOKE) at /home/520428/work/cortx-motr/rm/rm_fops.c:351 11 m0_rm_request_out (otype=otype@entry=M0_ROT_REVOKE, in=in@entry=0x7f773f0e63d0, loan=loan@entry=0x7f77a419d000, credit=credit@entry=0x7f77553f3750, other=other@entry=0x7f77a419ce50) at /home/520428/work/cortx-motr/rm/rm_fops.c:392 12 0x00007f77afca65df in revoke_send (credit=0x7f77a419d000, loan=0x7f77a419d000, in=0x7f773f0e63d0) at rm/rm.c:2633 13 incoming_check_with (rest=0x7f77553f36f0, in=0x7f773f0e63d0) at rm/rm.c:2437 14 incoming_check (in=0x7f773f0e63d0) at rm/rm.c:2060 15 owner_balance (o=o@entry=0x7f77a41ca0d0) at rm/rm.c:1995 16 0x00007f77afca6cdc in owner_liquidate (o=0x7f77a41ca0d0) at rm/rm.c:864 17 owner_finalisation_check (owner=0x7f77a41ca0d0) at rm/rm.c:551 18 owner_balance (o=o@entry=0x7f77a41ca0d0) at rm/rm.c:2002 19 0x00007f77afca6eb4 in owner_windup_locked (owner=owner@entry=0x7f77a41ca0d0) at rm/rm.c:927 20 0x00007f77afca6f38 in m0_rm_owner_windup (owner=owner@entry=0x7f77a41ca0d0) at rm/rm.c:936 21 0x00007f77afcaa309 in rms_resources_free (rtype=rtype@entry=0x7f773f0ed370) at rm/rm_service.c:183 22 0x00007f77afcaa3ee in rms_stop (service=0x7f773f0ed030) at rm/rm_service.c:207 23 0x00007f77afc9da6e in m0_reqh_service_stop (service=service@entry=0x7f773f0ed030) at reqh/reqh_service.c:419 24 0x00007f77b12f2fab in cs_service_fini (service=0x7f773f0ed030) at /home/520428/work/cortx-motr/motr/setup.c:1190 25 0x00007f77b12f31d0 in reqh_context_services_fini (cctx=0x7f77b183e1a8 <sctx+40>, rctx=0x7f77b183e4b8 <sctx+824>) at /home/520428/work/cortx-motr/motr/setup.c:1216 26 cs_level_leave (module=<optimized out>) at /home/520428/work/cortx-motr/motr/setup.c:2849 27 0x00007f77afc757d0 in m0_module_fini (module=module@entry=0x7f77b184cc00 <sctx+60032>, level=level@entry=-1) at module/module.c:154 28 0x00007f77b12f6fcd in m0_cs_fini (cctx=cctx@entry=0x7f77b183e1a8 <sctx+40>) at /home/520428/work/cortx-motr/motr/setup.c:3056 29 0x00007f77afcc1009 in m0_rpc_server_stop (sctx=sctx@entry=0x7f77b183e180 <sctx>) at rpc/rpclib.c:89 30 0x00007f77b136f4fa in rm_service_stop (sctx=0x7f77b183e180 <sctx>) at rm/ut/rm_service.c:84 31 rm_svc_server (tid=<optimized out>) at rm/ut/rm_service.c:84 32 0x00007f77afc29f7a in m0_thread_trampoline (arg=arg@entry=0x7f77b5e92008 <rm_ctxs+8>) at lib/thread.c:117 33 0x00007f77afc357bd in uthread_trampoline (arg=0x7f77b5e92008 <rm_ctxs+8>) at lib/user_space/uthread.c:98 34 0x00007f77af2c915a in start_thread () from /lib64/libpthread.so.0 35 0x00007f77adbcedd3 in clone () from /lib64/libc.so.6 Signed-off-by: Hua Huang <hua.huang@seagate.com>
…found. This new mechanism is introduced in 2f43b29 . Signed-off-by: Hua Huang <hua.huang@seagate.com>
huanghua78
force-pushed
the
rmsvc_prepare_to_stop
branch
from
9682dd9 to
8a9fe7c
Compare
So, we must also do rms_resource_free() in rso_prepare_to_stop().
This patch fixes the rm-ut:rmvsv UT failure:
Thread 29 (Thread 0x7f77553f4700 (LWP 1763408)):
0 0x00007f77adb9ada8 in nanosleep () from /lib64/libc.so.6
1 0x00007f77adb9acae in sleep () from /lib64/libc.so.6
2 0x00007f77afc34af2 in m0_debugger_invoke () at lib/user_space/uassert.c:144
3 0x00007f77afc34c04 in m0_arch_panic (c=c@entry=0x7f77b00fa700 <signal_panic>, ap=ap@entry=0x7f77553f2538) at lib/user_space/uassert.c:129
4 0x00007f77afc22ba7 in m0_panic (ctx=ctx@entry=0x7f77b00fa700 <signal_panic>) at lib/assert.c:52
5 0x00007f77afc34c48 in sigsegv (sig=11) at lib/user_space/ucookie.c:52
6
7 m0_rpc_conn_is_snd (conn=0x5f5f5f5f5f5f5f5f) at rpc/conn.c:282
8 0x00007f77afcbe0a1 in m0_rpc_post (item=item@entry=0x7f773d820130) at /home/520428/work/cortx-motr/rpc/rpc_internal.h:97
9 0x00007f77b136c498 in m0_rm_outgoing_send (outgoing=outgoing@entry=0x7f773d820050) at /home/520428/work/cortx-motr/rm/rm_fops.c:310
10 0x00007f77b136c7dd in outgoing_queue (other=0x7f77a419ce50, in=0x7f773f0e63d0, outreq=0x7f773d820050, owner=0x7f77a41ca0d0, otype=M0_ROT_REVOKE)
at /home/520428/work/cortx-motr/rm/rm_fops.c:351
11 m0_rm_request_out (otype=otype@entry=M0_ROT_REVOKE, in=in@entry=0x7f773f0e63d0, loan=loan@entry=0x7f77a419d000, credit=credit@entry=0x7f77553f3750,
other=other@entry=0x7f77a419ce50) at /home/520428/work/cortx-motr/rm/rm_fops.c:392
12 0x00007f77afca65df in revoke_send (credit=0x7f77a419d000, loan=0x7f77a419d000, in=0x7f773f0e63d0) at rm/rm.c:2633
13 incoming_check_with (rest=0x7f77553f36f0, in=0x7f773f0e63d0) at rm/rm.c:2437
14 incoming_check (in=0x7f773f0e63d0) at rm/rm.c:2060
15 owner_balance (o=o@entry=0x7f77a41ca0d0) at rm/rm.c:1995
16 0x00007f77afca6cdc in owner_liquidate (o=0x7f77a41ca0d0) at rm/rm.c:864
17 owner_finalisation_check (owner=0x7f77a41ca0d0) at rm/rm.c:551
18 owner_balance (o=o@entry=0x7f77a41ca0d0) at rm/rm.c:2002
19 0x00007f77afca6eb4 in owner_windup_locked (owner=owner@entry=0x7f77a41ca0d0) at rm/rm.c:927
20 0x00007f77afca6f38 in m0_rm_owner_windup (owner=owner@entry=0x7f77a41ca0d0) at rm/rm.c:936
21 0x00007f77afcaa309 in rms_resources_free (rtype=rtype@entry=0x7f773f0ed370) at rm/rm_service.c:183
22 0x00007f77afcaa3ee in rms_stop (service=0x7f773f0ed030) at rm/rm_service.c:207
23 0x00007f77afc9da6e in m0_reqh_service_stop (service=service@entry=0x7f773f0ed030) at reqh/reqh_service.c:419
24 0x00007f77b12f2fab in cs_service_fini (service=0x7f773f0ed030) at /home/520428/work/cortx-motr/motr/setup.c:1190
25 0x00007f77b12f31d0 in reqh_context_services_fini (cctx=0x7f77b183e1a8 <sctx+40>, rctx=0x7f77b183e4b8 <sctx+824>) at /home/520428/work/cortx-motr/motr/setup.c:1216
26 cs_level_leave (module=) at /home/520428/work/cortx-motr/motr/setup.c:2849
27 0x00007f77afc757d0 in m0_module_fini (module=module@entry=0x7f77b184cc00 <sctx+60032>, level=level@entry=-1) at module/module.c:154
28 0x00007f77b12f6fcd in m0_cs_fini (cctx=cctx@entry=0x7f77b183e1a8 <sctx+40>) at /home/520428/work/cortx-motr/motr/setup.c:3056
29 0x00007f77afcc1009 in m0_rpc_server_stop (sctx=sctx@entry=0x7f77b183e180 ) at rpc/rpclib.c:89
30 0x00007f77b136f4fa in rm_service_stop (sctx=0x7f77b183e180 ) at rm/ut/rm_service.c:84
31 rm_svc_server (tid=) at rm/ut/rm_service.c:84
32 0x00007f77afc29f7a in m0_thread_trampoline (arg=arg@entry=0x7f77b5e92008 <rm_ctxs+8>) at lib/thread.c:117
33 0x00007f77afc357bd in uthread_trampoline (arg=0x7f77b5e92008 <rm_ctxs+8>) at lib/user_space/uthread.c:98
34 0x00007f77af2c915a in start_thread () from /lib64/libpthread.so.0
35 0x00007f77adbcedd3 in clone () from /lib64/libc.so.6
Actual pver is returned in case when nothing better (cleaner) can be found.
This new mechanism is introduced in 2f43b29 .
Problem Statement
Design
Coding
Checklist for Author
Testing
Checklist for Author
Impact Analysis
Checklist for Author/Reviewer/GateKeeper
Review Checklist
Checklist for Author
Documentation
Checklist for Author