-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add notebook test deps to integration tesets requirements file #1535
Conversation
Wed Mar 11 23:19:22 UTC 2020 impatient try |
Wed Mar 11 23:19:23 UTC 2020 impatient try |
/test integration |
Wed Mar 11 23:22:33 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test integration |
Thu Mar 12 07:44:04 UTC 2020 impatient try |
Actually... started to think if I need to increment |
Hmm... very interesting error message in the last failure: ---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
/workspace/source/examples/istio/canary_update/canary.py in <module>
158
159
--> 160 predict_rest_mnist(mnist,"mnist-classifier","seldon",ISTIO_GATEWAY)
161
162
/workspace/source/examples/istio/canary_update/canary.py in predict_rest_mnist(mnist, deployment_name, namespace, istio_gateway)
113 r = sc.predict(gateway="istio",transport="rest",shape=(1,784),data=data,payload_type='ndarray',names=features)
114 predictions = r.response
--> 115 fpreds = [ '%.2f' % elem for elem in predictions["data"]["ndarray"][0] ]
116 m = dict(zip(predictions["data"]["names"],fpreds))
117 print(json.dumps(m,indent=2))
TypeError: 'NoneType' object is not subscriptable edit: actually not that interesting, it's probably due to |
/test integration |
Thu Mar 12 12:00:49 UTC 2020 impatient try |
Thu Mar 12 12:01:48 UTC 2020 impatient try |
Thu Mar 12 12:02:27 UTC 2020 impatient try |
closes #1504