Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notebook test deps to integration tesets requirements file #1535

Merged
merged 1 commit into from
Mar 12, 2020
Merged

add notebook test deps to integration tesets requirements file #1535

merged 1 commit into from
Mar 12, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

closes #1504

@seldondev
Copy link
Collaborator

Wed Mar 11 23:19:22 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1535/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1535 --build=1

@seldondev
Copy link
Collaborator

Wed Mar 11 23:19:23 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1535/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1535 --build=2

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Mar 11 23:22:33 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1535/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1535 --build=3

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Thu Mar 12 07:44:04 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1535/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1535 --build=4

@RafalSkolasinski
Copy link
Contributor Author

RafalSkolasinski commented Mar 12, 2020

Actually... started to think if I need to increment DOCKER_IMAGE_VERSION=0.13 and push new image to hub for it to work? @cliveseldon

@RafalSkolasinski
Copy link
Contributor Author

RafalSkolasinski commented Mar 12, 2020

Hmm... very interesting error message in the last failure:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/workspace/source/examples/istio/canary_update/canary.py in <module>
    158 
    159 
--> 160 predict_rest_mnist(mnist,"mnist-classifier","seldon",ISTIO_GATEWAY)
    161 
    162 
/workspace/source/examples/istio/canary_update/canary.py in predict_rest_mnist(mnist, deployment_name, namespace, istio_gateway)
    113     r = sc.predict(gateway="istio",transport="rest",shape=(1,784),data=data,payload_type='ndarray',names=features)
    114     predictions = r.response
--> 115     fpreds = [ '%.2f' % elem for elem in predictions["data"]["ndarray"][0] ]
    116     m = dict(zip(predictions["data"]["names"],fpreds))
    117     print(json.dumps(m,indent=2))
TypeError: 'NoneType' object is not subscriptable

edit: actually not that interesting, it's probably due to r.response being None

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Mar 12 12:00:49 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1535/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1535 --build=7

@seldondev
Copy link
Collaborator

Thu Mar 12 12:01:48 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1535/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1535 --build=5

@seldondev
Copy link
Collaborator

Thu Mar 12 12:02:27 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1535/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1535 --build=6

@seldondev seldondev merged commit 574ac86 into SeldonIO:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing python dependencies for integration tests
3 participants