Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notebook test deps to integration tesets requirements file #1535

Merged
merged 1 commit into from
Mar 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core-builder/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dev_requirements.txt
10 changes: 4 additions & 6 deletions core-builder/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ RUN rm -rf /usr/local/bin/pip && \

RUN pip install --upgrade pip
RUN pip install --upgrade setuptools
RUN pip install pyyaml
RUN pip install pyyaml
RUN pip install grpcio
RUN pip install grpcio-tools
RUN apt-get remove -y --auto-remove && apt-get clean -y && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
Expand Down Expand Up @@ -120,14 +120,12 @@ RUN go get github.com/fullstorydev/grpcurl && \
go install github.com/fullstorydev/grpcurl/cmd/grpcurl

ENV PATH="${PATH}:/root/go/bin"

# Notebooks python requirements
RUN pip install alibi && \
pip install matplotlib && \
pip install keras
COPY dev_requirements.txt /tmp/requirements.txt
RUN pip install -r /tmp/requirements.txt

WORKDIR /work

# Define default command.
CMD ["bash"]

4 changes: 2 additions & 2 deletions core-builder/Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
DOCKER_IMAGE_NAME=seldonio/core-builder
DOCKER_IMAGE_VERSION=0.13
DOCKER_IMAGE_VERSION=0.14

build_docker_image:
cp ../testing/scripts/dev_requirements.txt .
docker build --force-rm=true -t $(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION) .
push_to_registry:
docker push $(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION)

1 change: 1 addition & 0 deletions testing/scripts/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ build_protos:

install:
pip install -r dev_requirements.txt
pip install -e ../../python

.PHONY: test
test: build_protos install
Expand Down
10 changes: 7 additions & 3 deletions testing/scripts/dev_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@ pytest-cov==2.8.1
flaky==3.6.1
tenacity==6.0.0

# notebooks test deps
ipython==7.13.0
nbconvert==5.6.1
alibi==0.3.2
matplotlib==3.1.3
tensorflow==1.15.2

# 2nd lvl dep on cov required to avoid sqllite dep
coverage==4.5.4

# local seldon-core
-e ../../python