Basic support for Cloudevents with KNative Eventing Example #1572

axsaucedo · 2020-03-21T15:12:46Z

[PR is currently blocked by https://github.com/kubernetes-sigs/controller-tools/issues/391]

This PR contains basic support for cloudevents with knative eventing, including:

Executor returns Cloudevent headers by default
Standardised type and source for triggers to be created aligned to each seldon deployment
Addition of duckv1.Addressable for duck typing when trigger references SeldonDeployment
Example notebook that shows how to leverage this knative basic flow

Key things to consider:

Currently duckv1.Addressable points to the predictions endpoint, and not to explanations, meta, etc
Without Ingress, it becomes ambiguous which predictor to expose as duckv1.Addressable
If authentication is enabled on ingress, it would become a challenge for the current setup (although it could be set up to manually reach for a custom endpoint)
It could also be possible to automatically create the triggers given that the types are now standardised as seldon.<deploymentname>.request (and suffix changes to .response for the return value)

Outstanding:

Add test to function that creates addressable resources
Add test that ensures header object always initialised with deploymentName
Confirm Ambassador flow (as there is option for non namespaced)
Confirm whether we want to have dynamic service URI discrovery for ambassador and istio
Generate CRDs with new properties

…ting

…eaders

review-notebook-app · 2020-03-21T15:12:52Z

Check out this pull request on

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

seldondev · 2020-03-21T15:14:26Z

Sat Mar 21 15:14:25 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=1

seldondev · 2020-03-21T15:14:30Z

Sat Mar 21 15:14:28 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=2

seldondev · 2020-03-23T18:37:47Z

Mon Mar 23 18:37:46 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=4

seldondev · 2020-03-23T18:38:19Z

Mon Mar 23 18:38:17 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=3

…ting

seldondev · 2020-03-23T18:53:24Z

Mon Mar 23 18:53:22 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=6

seldondev · 2020-03-23T18:53:32Z

Mon Mar 23 18:53:31 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=5

axsaucedo · 2020-03-23T19:23:14Z

I have run into a blocker that doesn't allow the build of the controller, currently an open issue here: kubernetes-sigs/controller-tools#391

seldondev · 2020-03-28T13:00:24Z

Sat Mar 28 13:00:23 UTC 2020
The logs for [lint] [29] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/29.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=29

seldondev · 2020-03-28T13:01:31Z

Sat Mar 28 13:01:30 UTC 2020
The logs for [pr-build] [28] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/28.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=28

… addressable URL

seldondev · 2020-03-28T13:45:29Z

Sat Mar 28 13:45:28 UTC 2020
The logs for [pr-build] [30] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/30.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=30

seldondev · 2020-03-28T13:46:32Z

Sat Mar 28 13:46:31 UTC 2020
The logs for [lint] [31] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/31.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=31

seldondev · 2020-03-28T13:49:55Z

Sat Mar 28 13:49:54 UTC 2020
The logs for [lint] [33] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/33.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=33

seldondev · 2020-03-28T13:49:56Z

Sat Mar 28 13:49:55 UTC 2020
The logs for [pr-build] [32] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/32.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=32

axsaucedo · 2020-03-28T13:50:10Z

@cliveseldon all comments have been resolved, it no longer reaches directly to the ingress (and reaches to the service itself), and the cloud events are only returned for cloud event types.

…ting

seldondev · 2020-03-30T15:13:56Z

Mon Mar 30 15:13:55 UTC 2020
The logs for [pr-build] [34] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/34.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=34

seldondev · 2020-03-30T15:13:57Z

Mon Mar 30 15:13:56 UTC 2020
The logs for [lint] [35] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/35.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=35

axsaucedo · 2020-03-30T15:14:08Z

/test integration

seldondev · 2020-03-30T15:15:50Z

Mon Mar 30 15:15:49 UTC 2020
The logs for [integration] [36] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/36.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=36

executor/api/rest/server_test.go

operator/controllers/seldondeployment_controller.go

ukclivecox · 2020-03-30T16:19:53Z

@axsaucedo A few small comments and then I think we are close to merge

axsaucedo · 2020-03-30T16:53:10Z

/test integration

seldondev · 2020-03-30T16:53:51Z

Mon Mar 30 16:53:49 UTC 2020
The logs for [pr-build] [37] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/37.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=37

seldondev · 2020-03-30T16:54:11Z

Mon Mar 30 16:54:10 UTC 2020
The logs for [lint] [38] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/38.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=38

seldondev · 2020-03-30T16:54:38Z

Mon Mar 30 16:54:37 UTC 2020
The logs for [integration] [39] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1572/39.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1572 --build=39

seldondev · 2020-03-30T17:38:10Z

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
integration	`bcbbc3f`	link	`/test integration`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ukclivecox · 2020-03-30T18:38:53Z

/approve

seldondev · 2020-03-30T18:39:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cliveseldon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

axsaucedo added 12 commits March 17, 2020 11:43

Added logic to set the header on the response and added test

a1f7c91

Added test for request

0e4750f

Added test for request and added checks on setting header

a013477

Merge remote-tracking branch 'upstream/master' into 1413_knative_even…

a89bbeb

…ting

Added example

41f7f78

ADded initial working example

ebb2fa6

Added duckv1 into the types

f11efa3

Merge remote-tracking branch 'upstream/master' into 1413_knative_even…

b8f0c64

…ting

Added operator addressable status and standardised types on request h…

7908db1

…eaders

Updated readme

4d15c70

Updated readme

9c51b06

Removed a todo comment

22aaf82

axsaucedo requested a review from ukclivecox March 21, 2020 15:12

seldondev added the do-not-merge/work-in-progress label Mar 21, 2020

seldondev requested review from adriangonz and arnaudvl March 21, 2020 15:12

seldondev added the size/XXL label Mar 21, 2020

axsaucedo removed the request for review from arnaudvl March 21, 2020 15:13

axsaucedo added 2 commits March 23, 2020 18:27

Added tests for addressable creation

5a5e480

Added tests on controller

180513a

Merge remote-tracking branch 'upstream/master' into 1413_knative_even…

9245333

…ting

axsaucedo mentioned this pull request Mar 23, 2020

markers to skip fields that does not have json tags for crd generation kubernetes-sigs/controller-tools#391

Closed

axsaucedo added 3 commits March 28, 2020 13:01

Added comment to link to issue related to 1611

ce32809

Removed all references to ingress related access

4789a08

Added fully working example of knative eventing with service-specific…

5dce599

… addressable URL

Removed changes that were added on merge

94449bd

Merge remote-tracking branch 'upstream/master' into 1412_knative_even…

173b547

…ting

ukclivecox reviewed Mar 30, 2020

View reviewed changes

executor/api/rest/server_test.go Outdated Show resolved Hide resolved

ukclivecox reviewed Mar 30, 2020

View reviewed changes

executor/api/rest/server_test.go Outdated Show resolved Hide resolved

ukclivecox reviewed Mar 30, 2020

View reviewed changes

operator/controllers/seldondeployment_controller.go Outdated Show resolved Hide resolved

Added function to get the name of the sdep service

bcbbc3f

seldondev added the approved label Mar 30, 2020

ukclivecox merged commit df3a57d into SeldonIO:master Mar 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic support for Cloudevents with KNative Eventing Example #1572

Basic support for Cloudevents with KNative Eventing Example #1572

axsaucedo commented Mar 21, 2020 •

edited

Loading

review-notebook-app bot commented Mar 21, 2020

seldondev commented Mar 21, 2020

seldondev commented Mar 21, 2020

seldondev commented Mar 23, 2020

seldondev commented Mar 23, 2020

seldondev commented Mar 23, 2020

seldondev commented Mar 23, 2020

axsaucedo commented Mar 23, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

axsaucedo commented Mar 28, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

axsaucedo commented Mar 30, 2020

seldondev commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

axsaucedo commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

seldondev commented Mar 30, 2020

Basic support for Cloudevents with KNative Eventing Example #1572

Basic support for Cloudevents with KNative Eventing Example #1572

Conversation

axsaucedo commented Mar 21, 2020 • edited Loading

review-notebook-app bot commented Mar 21, 2020

seldondev commented Mar 21, 2020

seldondev commented Mar 21, 2020

seldondev commented Mar 23, 2020

seldondev commented Mar 23, 2020

seldondev commented Mar 23, 2020

seldondev commented Mar 23, 2020

axsaucedo commented Mar 23, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

seldondev commented Mar 28, 2020

axsaucedo commented Mar 28, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

axsaucedo commented Mar 30, 2020

seldondev commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

axsaucedo commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

seldondev commented Mar 30, 2020

axsaucedo commented Mar 21, 2020 •

edited

Loading