Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seldon-core-operator Helm to fix bugs #1983

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Update seldon-core-operator Helm to fix bugs #1983

merged 3 commits into from
Jun 29, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1977
Fixes #1982

  • Ensure rbac is not created if set to false
  • Ensure serviceAccount name for manager can be changed

@seldondev seldondev requested review from arnaudvl and gsunner June 19, 2020 12:57
@ukclivecox ukclivecox requested review from axsaucedo and removed request for gsunner and arnaudvl June 19, 2020 12:57
@seldondev
Copy link
Collaborator

Fri Jun 19 12:58:44 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1983/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1983 --build=2

@seldondev
Copy link
Collaborator

Fri Jun 19 12:58:59 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1983/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1983 --build=1

@ukclivecox ukclivecox changed the title Update seldon-core-operator Helm to fix bugs WIP: Update seldon-core-operator Helm to fix bugs Jun 19, 2020
@seldondev seldondev added size/M and removed size/S labels Jun 19, 2020
@ukclivecox ukclivecox changed the title WIP: Update seldon-core-operator Helm to fix bugs Update seldon-core-operator Helm to fix bugs Jun 19, 2020
@seldondev
Copy link
Collaborator

Fri Jun 19 14:18:10 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1983/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1983 --build=4

@seldondev
Copy link
Collaborator

Fri Jun 19 14:18:43 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1983/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1983 --build=5

@ukclivecox ukclivecox requested a review from ryandawsonuk June 29, 2020 07:55
Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ltgm
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Jun 29 12:51:45 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1983/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1983 --build=7

@seldondev
Copy link
Collaborator

Mon Jun 29 12:52:05 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1983/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1983 --build=6

@seldondev seldondev merged commit 59da516 into SeldonIO:master Jun 29, 2020
@seldondev
Copy link
Collaborator

Mon Jul 6 11:39:02 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1983/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1983 --build=3

@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref d8fff2c
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha d8fff2c
  • failed to process repo SeldonIO/seldon-core refref d8fff2c
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm switch rbac.create=false does not fully work serviceAccount.name not used in Helm chart templates
3 participants