update version of operator in executor deps #2121

RafalSkolasinski · 2020-07-13T17:13:24Z

Closes #2091
Closes #2134

Most changes in this PR are related to 3b4c990#diff-d7ca7b021e6d991a2ce6ffca9a69e42d in which PredictorSpec.PredictiveUnit stopped being a pointer.

This is because we bumped version as:
v0.0.0-20200401123312-d4c435ea5217 -> v0.0.0-20200713173314-b8a92914e17e

Update:
In last commit I explore possibility to use local copy of operator.

RafalSkolasinski · 2020-07-13T17:14:51Z

/test integration
/test notebooks

seldondev · 2020-07-13T17:15:24Z

Mon Jul 13 17:15:22 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=1

seldondev · 2020-07-13T17:15:26Z

Mon Jul 13 17:15:25 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=2

seldondev · 2020-07-13T17:16:52Z

Mon Jul 13 17:16:50 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=3

seldondev · 2020-07-13T17:17:02Z

Mon Jul 13 17:16:59 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=4

seldondev · 2020-07-13T17:42:53Z

Mon Jul 13 17:42:52 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=5

seldondev · 2020-07-13T17:43:17Z

Mon Jul 13 17:43:15 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=6

seldondev · 2020-07-13T17:43:40Z

Mon Jul 13 17:43:38 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=7

seldondev · 2020-07-13T17:43:46Z

Mon Jul 13 17:43:43 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=8

RafalSkolasinski · 2020-07-13T18:19:34Z

/hold

I noticed that operator has go.uber.org/zap v1.10.0 but go.uber.org/zap v1.15.0 is available. Let's merge that into operator first. Opening PR shortly.

RafalSkolasinski · 2020-07-13T18:23:27Z

After #2122 is merged I will update this PR.

seldondev · 2020-07-14T09:51:55Z

Tue Jul 14 09:51:54 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=10

seldondev · 2020-07-14T09:51:57Z

Tue Jul 14 09:51:56 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=9

seldondev · 2020-07-14T09:54:55Z

Tue Jul 14 09:54:54 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=12

seldondev · 2020-07-14T09:55:20Z

Tue Jul 14 09:55:19 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=11

RafalSkolasinski · 2020-07-14T09:56:25Z

/test notebooks
/test integration

seldondev · 2020-07-14T09:58:20Z

Tue Jul 14 09:58:18 UTC 2020
The logs for [notebooks] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=13

seldondev · 2020-07-14T09:58:52Z

Tue Jul 14 09:58:49 UTC 2020
The logs for [integration] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=14

seldondev · 2020-07-14T10:19:14Z

Tue Jul 14 10:19:12 UTC 2020
The logs for [lint] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=16

seldondev · 2020-07-14T10:19:45Z

Tue Jul 14 10:19:43 UTC 2020
The logs for [pr-build] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=15

RafalSkolasinski · 2020-07-14T14:03:46Z

Executing tests again as they were garbage collected before I could take a look at results...
/test notebooks
/test integration

seldondev · 2020-07-14T14:05:34Z

Tue Jul 14 14:05:30 UTC 2020
The logs for [notebooks] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=17

seldondev · 2020-07-14T14:05:43Z

Tue Jul 14 14:05:42 UTC 2020
The logs for [integration] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=18

RafalSkolasinski · 2020-07-14T15:32:39Z

Rebased on #2129 and should go after this one (as there most likely be a tiny merge conflict)

seldondev · 2020-07-14T15:33:13Z

Tue Jul 14 15:33:12 UTC 2020
The logs for [pr-build] [19] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/19.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=19

seldondev · 2020-07-14T15:33:14Z

Tue Jul 14 15:33:13 UTC 2020
The logs for [lint] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=20

RafalSkolasinski · 2020-07-14T19:29:36Z

/unhold

rebased on master as #2129 got merged

/test integration
/test notebooks

seldondev · 2020-07-14T19:30:22Z

Tue Jul 14 19:30:21 UTC 2020
The logs for [pr-build] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=21

seldondev · 2020-07-14T19:30:29Z

Tue Jul 14 19:30:28 UTC 2020
The logs for [lint] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=22

seldondev · 2020-07-14T19:31:21Z

Tue Jul 14 19:31:18 UTC 2020
The logs for [notebooks] [23] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/23.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=23

seldondev · 2020-07-14T19:31:38Z

Tue Jul 14 19:31:36 UTC 2020
The logs for [integration] [24] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/24.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=24

RafalSkolasinski · 2020-07-14T19:32:58Z

/hold cancel

RafalSkolasinski · 2020-07-14T21:19:00Z

Integrations passed. Waiting for notebooks.

RafalSkolasinski · 2020-07-14T22:03:51Z

Notebooks passed as well!
Ready to landm @axsaucedo 🚀

ukclivecox · 2020-07-15T10:42:23Z

/lgtm

seldondev · 2020-07-15T10:42:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cliveseldon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RafalSkolasinski · 2020-07-15T10:50:34Z

Initiating manual merge as tests passed but their status on Github didn't get updated.

seldondev added the size/L label Jul 13, 2020

seldondev added the do-not-merge/hold label Jul 13, 2020

RafalSkolasinski marked this pull request as draft July 13, 2020 18:23

seldondev added the do-not-merge/work-in-progress label Jul 14, 2020

RafalSkolasinski marked this pull request as ready for review July 14, 2020 14:01

seldondev removed the do-not-merge/work-in-progress label Jul 14, 2020

RafalSkolasinski added 2 commits July 14, 2020 20:27

update version of operator in executor deps

c2266ff

use local copy of operator in executor build

c319070

seldondev removed the do-not-merge/hold label Jul 14, 2020

RafalSkolasinski mentioned this pull request Jul 15, 2020

Update dependencies of Operator and Executor #2088

Closed

19 tasks

RafalSkolasinski requested review from ukclivecox and axsaucedo and removed request for ukclivecox July 15, 2020 08:29

seldondev assigned ukclivecox Jul 15, 2020

seldondev added the lgtm label Jul 15, 2020

seldondev added the approved label Jul 15, 2020

RafalSkolasinski merged commit 31f2cac into SeldonIO:master Jul 15, 2020

update version of operator in executor deps #2121

update version of operator in executor deps #2121

Conversation

RafalSkolasinski commented Jul 13, 2020 • edited Loading

RafalSkolasinski commented Jul 13, 2020

seldondev commented Jul 13, 2020

seldondev commented Jul 13, 2020

seldondev commented Jul 13, 2020

seldondev commented Jul 13, 2020

seldondev commented Jul 13, 2020

seldondev commented Jul 13, 2020

seldondev commented Jul 13, 2020

seldondev commented Jul 13, 2020

RafalSkolasinski commented Jul 13, 2020

RafalSkolasinski commented Jul 13, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

RafalSkolasinski commented Jul 14, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

RafalSkolasinski commented Jul 14, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

RafalSkolasinski commented Jul 14, 2020 • edited Loading

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

RafalSkolasinski commented Jul 14, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

seldondev commented Jul 14, 2020

RafalSkolasinski commented Jul 14, 2020

RafalSkolasinski commented Jul 14, 2020

RafalSkolasinski commented Jul 14, 2020

ukclivecox commented Jul 15, 2020

seldondev commented Jul 15, 2020

RafalSkolasinski commented Jul 15, 2020

RafalSkolasinski commented Jul 13, 2020 •

edited

Loading

RafalSkolasinski commented Jul 14, 2020 •

edited

Loading