Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump zap from v1.10.0 to v1.15.0 #2122

Closed
wants to merge 2 commits into from
Closed

bump zap from v1.10.0 to v1.15.0 #2122

wants to merge 2 commits into from

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jul 13, 2020

Closes #2127

Bumps zap from v1.10.0 to v1.15.0.

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks
/test integration

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Jul 13 18:24:45 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=2

@seldondev
Copy link
Collaborator

Mon Jul 13 18:24:58 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=1

@seldondev
Copy link
Collaborator

Mon Jul 13 18:25:04 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=3

@seldondev
Copy link
Collaborator

Mon Jul 13 18:26:30 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=4

@RafalSkolasinski
Copy link
Contributor Author

RafalSkolasinski commented Jul 13, 2020

  • integration passed
  • 1 notebook failed: TestNotebooks.test_istio_canary

/test notebooks

@seldondev
Copy link
Collaborator

Mon Jul 13 21:32:48 UTC 2020
The logs for [notebooks] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=5

@RafalSkolasinski
Copy link
Contributor Author

RafalSkolasinski commented Jul 14, 2020

No results of notebook tests available. Re-triggering.

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Tue Jul 14 08:39:20 UTC 2020
The logs for [notebooks] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=6

@RafalSkolasinski
Copy link
Contributor Author

again failure on TestNotebooks.test_istio_canary

@axsaucedo
Copy link
Contributor

@RafalSkolasinski if it's only that test can you try running locally? It woudl be good to confirm if there are issues given same test failed twice

@axsaucedo
Copy link
Contributor

I just ran the istio test locally. It makes sense why the zap change may be causing this (although not sure how it didn't fail for 0.10 unless it's a expected). The count of requests is done by counting the logs in the executor via canary_count=!kubectl logs $(kubectl get pod -l seldon-app=mnist-classifier-tf-mnist-predictor -o jsonpath='{.items[0].metadata.name}') seldon-container-engine | grep "Predictions called" | wc -l

I can see the requests going through via logs of the model. But the executor seems to no longer print the logs. So if this test didn't fail initially when zap 0.10 was added, it means that either they may have changed their defaults, or currently the log printing isn't working. I'll catch up with @adriangonz to see if this may be config or a nuanced change in their API.

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks
/test integration

@axsaucedo
Copy link
Contributor

/test notebooks

@seldondev
Copy link
Collaborator

Tue Jul 14 13:19:43 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=7

@seldondev
Copy link
Collaborator

Tue Jul 14 13:19:50 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=8

@seldondev
Copy link
Collaborator

Tue Jul 14 13:21:06 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=10

@seldondev
Copy link
Collaborator

Tue Jul 14 13:21:17 UTC 2020
The logs for [notebooks] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=11

@seldondev
Copy link
Collaborator

Tue Jul 14 13:22:13 UTC 2020
The logs for [notebooks] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2122/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2122 --build=9

@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint 2002b48 link /test lint
pr-build 2002b48 link /test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@RafalSkolasinski
Copy link
Contributor Author

Replaced by #2129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump zap from v1.10.0 to v1.15.0
3 participants