-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump zap from v1.10.0 to v1.15.0 #2122
Conversation
/test notebooks |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mon Jul 13 18:24:45 UTC 2020 impatient try |
Mon Jul 13 18:24:58 UTC 2020 impatient try |
Mon Jul 13 18:25:04 UTC 2020 impatient try |
Mon Jul 13 18:26:30 UTC 2020 impatient try |
/test notebooks |
Mon Jul 13 21:32:48 UTC 2020 impatient try |
No results of notebook tests available. Re-triggering. |
/test notebooks |
Tue Jul 14 08:39:20 UTC 2020 impatient try |
again failure on TestNotebooks.test_istio_canary |
@RafalSkolasinski if it's only that test can you try running locally? It woudl be good to confirm if there are issues given same test failed twice |
I just ran the istio test locally. It makes sense why the zap change may be causing this (although not sure how it didn't fail for 0.10 unless it's a expected). The count of requests is done by counting the logs in the executor via I can see the requests going through via logs of the model. But the executor seems to no longer print the logs. So if this test didn't fail initially when zap 0.10 was added, it means that either they may have changed their defaults, or currently the log printing isn't working. I'll catch up with @adriangonz to see if this may be config or a nuanced change in their API. |
/test notebooks |
/test notebooks |
Tue Jul 14 13:19:43 UTC 2020 impatient try |
Tue Jul 14 13:19:50 UTC 2020 impatient try |
Tue Jul 14 13:21:06 UTC 2020 impatient try |
Tue Jul 14 13:21:17 UTC 2020 impatient try |
Tue Jul 14 13:22:13 UTC 2020 impatient try |
@RafalSkolasinski: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Replaced by #2129 |
Closes #2127
Bumps zap from v1.10.0 to v1.15.0.