Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore enabling send_feedback path for tensorflow protocol #2688

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

axsaucedo
Copy link
Contributor

Fixes: #2665

Implementation enables:

  • Feedback to be used with tensorflow protocol
  • Currently limited to REST
  • Would work with current batch demo (sending feedback, seeing accuracy/precision/etc)

Current considerations:

  • Payload is sent to request logger until it reaches PredictorProcess (so guard can't be in server.go)
  • Guard can't be in PredictorProcess as information about tensorflow protocol not available (pu.implementation cannot be used)
  • Guard can only be in the client.go, which has been added as initial assessment

Extensions to discuss in this PR:

  • Extend metrics server to work with Tensorflow schema - i.e. "instances" instead of "data.ndarray"
  • Documentation

Currently could be explored if it can be moved higher up in the PredictorProcess instead.

@seldondev
Copy link
Collaborator

Fri Nov 20 19:58:30 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2688/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2688 --build=2

@seldondev
Copy link
Collaborator

Fri Nov 20 19:58:29 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2688/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2688 --build=1

Copy link
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SachinVarghese
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SachinVarghese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SachinVarghese SachinVarghese changed the title WIP: Explore enabling send_feedback path for tensorflow protocol Explore enabling send_feedback path for tensorflow protocol Nov 23, 2020
@seldondev seldondev merged commit dbc4591 into SeldonIO:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore send_feedback path for tensorflow protocol
3 participants