Bug: Updated proto to correct type check on python wrapper #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test notebooks |
|
/test integration |
axsaucedo
changed the title
axsaucedo
changed the title
axsaucedo
force-pushed
the
3364_proto_send_feedback
branch
from
86f7d6e to
f66b8ce
Compare
|
/test notebooks |
|
@axsaucedo Is the main argument for this that |
RafalSkolasinski
approved these changes
Jul 13, 2021
|
@RafalSkolasinski yeah that's correct, it hasn't been updated to pass options for both dict and proto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2606
Build upon discussion in #3364
Special notes for your reviewer:
Does this PR introduce a user-facing change?: