Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minior: Fix knative wording #4771

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Mar 31, 2023

Fixes #

Special notes for your reviewer:

Just update the KNative writing to the proper Knative version. And fixed two typos on the eventing documentation

matzew added 2 commits March 31, 2023 08:01
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@seldondev
Copy link
Collaborator

Hi @matzew. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@ukclivecox
Copy link
Contributor

@matzew Thanks!

@ukclivecox ukclivecox merged commit e7bde6d into SeldonIO:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants