Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minior: Fix knative wording #4771

Merged
merged 2 commits into from
Mar 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/servers/batch.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Seldon Core provides a command line component that allows for highly parallelizable batch processing with the horizontally scalable seldon core kubernetes model deployments.

For stream processing with Seldon Core please see [Stream Processing with KNative Eventing](../streaming/knative_eventing.md).
For stream processing with Seldon Core please see [Stream Processing with Knative Eventing](../streaming/knative_eventing.md).

![](../images/batch-processor.jpg)

Expand Down
14 changes: 7 additions & 7 deletions doc/source/streaming/knative_eventing.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
# KNative Eventing Integration
# Knative Eventing Integration

Seldon has an integration with KNative eventing that allows for real time processing.
Seldon has an integration with Knative eventing that allows for real time processing.

This allow Seldon Core users to connect SeldonDeployments through triggers that will receive any relevant Cloudevents.

![](../images/stream-processing-knative.jpg)

## Triggers

The way that KNative Eventing works is by creating triggers that send any relevant Cloudevents that match a specific setup into the relevant addressable location.
The way that Knative Eventing works is by creating triggers that send any relevant Cloudevents that match a specific setup into the relevant addressable location.

Seldon Core implements the KNative Eventing Duck Typing requirements which allows users to create triggers that reference specific SeldonDeployments.
Seldon Core implements the Knative Eventing Duck Typing requirements which allows users to create triggers that reference specific SeldonDeployments.

An example of a trigger for a SeldonDeployment named "iris-deployment" can be created with the following format:

Expand Down Expand Up @@ -61,7 +61,7 @@ Which would then create a trigger that would forward the messages of that type i

## Sending Test Requests

In production you would have multiple services creating cloudevents from various different sources. However for testing, it's possible to send requests directly from your terminal to the KNative Eventing broker, by using the following `curl` docker image locally:
In production you would have multiple services creating cloudevents from various different sources. However for testing, it's possible to send requests directly from your terminal to the Knative Eventing broker, by using the following `curl` docker image locally:

```bash
kubectl run --quiet=true -it --rm curl --image=radial/busyboxplus:curl --restart=Never -- \
Expand All @@ -82,7 +82,7 @@ When receiving a Cloudevent, SeldonDeployments will return a Cloudevent-enabled

What this means is that you can create further triggers that could perform other actions with the resulting data.

THe triggers will have to match the cloudevent headers, which are standardised by the SeldonDEployment, and are of the following format:
The triggers will have to match the cloudevent headers, which are standardised by the SeldonDeployment, and are of the following format:

```text
Ce-Id: SeldonDeployment unique request ID
Expand Down Expand Up @@ -152,6 +152,6 @@ This will show all the cloudevents that are sent with that are processed by the

We have a fully worked notebook where we showcase these capabilities end to end.

You can try it yourself through the [Seldon Core Real Time Stream Processing with KNative Eventing](../examples/knative_eventing_streaming.nblink) page
You can try it yourself through the [Seldon Core Real Time Stream Processing with Knative Eventing](../examples/knative_eventing_streaming.nblink) page