-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] update SOC for driver finder and selenium manager classes #13386
Conversation
4ce5514
to
e31f1c3
Compare
I realized how inefficient some of the code has gotten, and missing a bunch of errors and logging opportunities and had to update all the specs accordingly. At this rate maybe I won't get this feature out for all the bindings before next release. 😂 |
9a1f9fa
to
d62a8b6
Compare
1d78e8d
to
13ea716
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13386 +/- ##
=======================================
Coverage 58.07% 58.07%
=======================================
Files 88 88
Lines 5340 5340
Branches 224 224
=======================================
Hits 3101 3101
Misses 2015 2015
Partials 224 224 ☔ View full report in Codecov by Sentry. |
e1864a8
to
8271e92
Compare
Sorry, made a bunch more changes, would appreciate another glance over. It should match what I have PR'd for Java & Python |
8271e92
to
e982247
Compare
e982247
to
18bdea1
Compare
CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
/analyze |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @titusfortner!
Hi @titusfortner, you wrote that |
ℹ️ this broke RubyGems.org build as well https://github.com/rubygems/rubygems.org/actions/runs/8834385973/job/24255908169?pr=4645 |
This was accidentally removed in #13386. Fixes #13876. Related to rails/rails#51658.
This was accidentally removed in #13386. Fixes #13876. Related to rails/rails#51658.
This was accidentally removed in #13386. Fixes #13876. Related to rails/rails#51658.
This was accidentally removed in #13386. Fixes #13876. Related to rails/rails#51658.
Description
LocalDriver
moduleMotivation and Context
DriverFinder
is not labeled private API, so deprecating instead of removing, not the case withSeleniumManager