-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable bzlmod in Bazel 7 #13726
Enable bzlmod in Bazel 7 #13726
Conversation
CI Failure Feedback(Checks updated until commit ede7ec4)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
11a30c3
to
05d6949
Compare
3a926e0
to
acc917b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13726 +/- ##
=======================================
Coverage 58.63% 58.63%
=======================================
Files 86 86
Lines 5272 5272
Branches 218 218
=======================================
Hits 3091 3091
Misses 1963 1963
Partials 218 218 ☔ View full report in Codecov by Sentry. |
d9a78cf
to
3ce0288
Compare
PR Description updated to latest commit (3ce0288)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
abed8d6
to
e2426d2
Compare
Waiting for release with fix bazelbuild/rules_rust@fc601ba
This reverts commit 2bb1177.
CI is as green as the master - https://github.com/SeleniumHQ/selenium/actions/runs/8739028246. |
User description
Migrates our build system to use Bzlmod, a new package manager for Bazel - https://bazel.build/external/overview
There are some smaller things that need to be done eventually:
Full CI build - https://github.com/SeleniumHQ/selenium/actions/runs/8486389973
Type
enhancement
Description
System.Environment.NewLine
usage in WebDriver Response for .NET.local_drivers
to be a direct repository rule.buildifier
load statement to use prebuilt package.third_party_prefixes
in Java distribution and Javadoc targets.Changes walkthrough
21 files
OutOfProcessSeleniumServer.java
Simplify Selenium Server Path Resolution in Tests
java/test/org/openqa/selenium/testing/drivers/OutOfProcessSeleniumServer.java
buildServerAndClasspath
method by updatingrlocation
path.JavaScriptTestSuite.java
Update JavaScript Test Suite URL Path
java/test/org/openqa/selenium/javascript/JavaScriptTestSuite.java
dynamicTests
method for JavaScript tests.TestFileLocator.java
Update Test Directory Resolution Path
java/test/org/openqa/selenium/javascript/TestFileLocator.java
getTestDirectory
method.InProject.java
Update Project Root Resolution Path
java/test/org/openqa/selenium/build/InProject.java
findProjectRoot
method.Response.cs
Standardize NewLine Usage in WebDriver Response
dotnet/src/webdriver/Response.cs
Environment.NewLine
withSystem.Environment.NewLine
forconsistency.
EnvironmentManager.cs
Update Environment Paths in Test Environment Manager
dotnet/test/common/Environment/EnvironmentManager.cs
EnvironmentManager
constructor.TestWebServer.cs
Update Standalone Test Jar Path
dotnet/test/common/Environment/TestWebServer.cs
TestWebServer
class.test_bootstrap.js
Update JavaScript Test Bootstrap Paths
javascript/webdriver/test/test_bootstrap.js
test_bootstrap.js
Update Chrome Driver Test Bootstrap Paths
javascript/chrome-driver/test/test_bootstrap.js
test_bootstrap.js
Update Atoms Test Bootstrap Paths
javascript/atoms/test/test_bootstrap.js
driver_spec.rb
Refine Test Exclusion Logic for Invalid Locator
rb/spec/integration/selenium/webdriver/driver_spec.rb
repositories.bzl
Enhance Browser Pinning and Add JS Library Targets
common/repositories.bzl
js_library
targets and update browser pinning configurations.pinned_browsers.py
Update Browser Pinning Script with JS Library Targets
scripts/pinned_browsers.py
js_library
targets.selenium_manager.py
Add Module Extension for Selenium Manager Artifacts
scripts/selenium_manager.py
selenium_manager.bzl
Implement Module Extension for Selenium Manager
common/selenium_manager.bzl
drivers.bzl
Refactor Local Drivers to Direct Repository Rule
common/private/drivers.bzl
local_drivers
to be a repository rule directly.maven_install.json
Update Maven Artifact Versions and Add Conflict Resolution
java/maven_install.json
WORKSPACE
Simplify WORKSPACE and Enable Bzlmod without Lockfile
WORKSPACE
BUILD.bazel
Update Buildifier Load Statement
BUILD.bazel
buildifier
load statement to use prebuilt package.BUILD.bazel
Update Third Party Prefixes in Java Distribution Target
java/src/org/openqa/selenium/grid/BUILD.bazel
third_party_prefixes
injava_dist_zip
target.BUILD.bazel
Update Third Party Prefixes in Java Client Javadoc Target
java/src/org/openqa/selenium/BUILD.bazel
third_party_prefixes
injava_dist_zip
target.5 files
.bazelrc
Enable Bzlmod and Set Environment Variable for Tests
.bazelrc
.bazelrc.remote
Add Remote Build Configuration
.bazelrc.remote
ci-java.yml
Update Java Version in GitHub Actions Workflow
.github/workflows/ci-java.yml
bazel.yml
Update External Cache Configuration in GitHub Actions Workflow
.github/workflows/bazel.yml
ci.yml
Update External Cache Configuration in GitHub Actions Workflow
.github/workflows/ci.yml
1 files
.skipped-tests
Add New Skipped Tests for .NET
.skipped-tests
1 files
README.md
Update JavaScript Atoms Tests URL in README
javascript/atoms/README.md