-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving ignore_local_proxy_environment_variables to BaseOptions #13926
Conversation
PR Description updated to latest commit (d3687d8)
|
PR Review 🔍
|
PR Code Suggestions ✨
|
CI Failure Feedback 🧐
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
…iumHQ#13926) * Moving ignore_local_proxy_environment_variables to BaseOptions * Just moving instead of deprecating * Invoking method instead of property
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Fixes #10755
Description
Motivation and Context
Types of changes
Checklist
PR Type
enhancement
Description
_ignore_local_proxy
and methodignore_local_proxy_environment_variables
fromArgOptions
toBaseOptions
.BaseOptions
to utilize the proxy environment variable ignoring functionality.ignore_local_proxy_environment_variables
inArgOptions
to set the attribute from the superclass, ensuring consistency across different browser options.Changes walkthrough 📝
options.py
Refactor Proxy Environment Variable Handling in BaseOptions
py/selenium/webdriver/common/options.py
_ignore_local_proxy
attribute toBaseOptions
class.ignore_local_proxy_environment_variables
method fromArgOptions
to
BaseOptions
.ignore_local_proxy_environment_variables
method inArgOptions
to use superclass attribute.