Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving ignore_local_proxy_environment_variables to BaseOptions #13926

Merged
merged 4 commits into from
May 13, 2024
Merged

Moving ignore_local_proxy_environment_variables to BaseOptions #13926

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4623f3f
Moving ignore_local_proxy_environment_variables to BaseOptions
diemol May 10, 2024
d3687d8
Just moving instead of deprecating
diemol May 10, 2024
ca3b5ae
Invoking method instead of property
diemol May 10, 2024
67ea93d
Merge branch 'trunk' into issue-10755
diemol May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions py/selenium/webdriver/common/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ def __init__(self) -> None:
self._proxy = None
self.set_capability("pageLoadStrategy", PageLoadStrategy.normal)
self.mobile_options = None
self._ignore_local_proxy = False

@property
def capabilities(self):
Expand Down Expand Up @@ -404,14 +405,18 @@ def to_capabilities(self):
def default_capabilities(self):
"""Return minimal capabilities necessary as a dictionary."""

def ignore_local_proxy_environment_variables(self) -> None:
"""By calling this you will ignore HTTP_PROXY and HTTPS_PROXY from
being picked up and used."""
self._ignore_local_proxy = True


class ArgOptions(BaseOptions):
BINARY_LOCATION_ERROR = "Binary Location Must be a String"

def __init__(self) -> None:
super().__init__()
self._arguments = []
self._ignore_local_proxy = False

@property
def arguments(self):
Expand All @@ -432,7 +437,7 @@ def add_argument(self, argument) -> None:
def ignore_local_proxy_environment_variables(self) -> None:
"""By calling this you will ignore HTTP_PROXY and HTTPS_PROXY from
being picked up and used."""
self._ignore_local_proxy = True
super().ignore_local_proxy_environment_variables()

def to_capabilities(self):
return self._caps
Expand Down
Loading