-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Update rules ruby to latest version and module #15282
Merged
VietND96
merged 6 commits into
SeleniumHQ:release-preparation-4.29.0
from
aguspe:rb_fix_dependancy_issue
Feb 19, 2025
Merged
[rb] Update rules ruby to latest version and module #15282
VietND96
merged 6 commits into
SeleniumHQ:release-preparation-4.29.0
from
aguspe:rb_fix_dependancy_issue
Feb 19, 2025
+39
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
ae2cce1
to
e5b6585
Compare
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
e5b6585
to
5e5bf3f
Compare
… rb_fix_dependancy_issue
d8afcc5
into
SeleniumHQ:release-preparation-4.29.0
22 of 23 checks passed
VietND96
added a commit
that referenced
this pull request
Feb 19, 2025
* Update pinned browser versions * Update supported versions for Chrome DevTools * Update selenium manager version * Update authors file * FIX CHANGELOGS BEFORE MERGING! Update versions and change logs to release Selenium 4.29.0 * [create-pull-request] automated change * Update CHANGELOG cross bindings * Update CHANGELOG for new upstream changes * Update CHANGELOG for a new change * [rb] Disable provide response test for Firefox (#15295) * [rb] Update rules ruby to latest version and module (#15282) * [ci] Update setup-bazel v0.13.0 --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: Selenium CI Bot <selenium-ci@users.noreply.github.com> Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: Augustin Gottlieb <33221555+aguspe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Motivation and Context
This PR fixes the dependency issue in Ruby to be able to build and release new versions of Selenium
The fix is to update the ruby rules version to 0.17.0, then Bazel can build the date gem dependency for JRuby
Files affected:
Bug overview:
Fix locally after building:
Types of changes
Checklist
PR Type
Enhancement, Dependencies
Description
Updated
rules_ruby
dependency to version 0.17.0.Upgraded several Ruby module dependencies to newer versions.
Added new checksum entries for updated Ruby modules.
Improved compatibility and resolved dependency issues for Ruby builds.
Changes walkthrough 📝
MODULE.bazel
Update `rules_ruby` and Ruby module dependencies
MODULE.bazel
rules_ruby
dependency from 0.13.0 to 0.17.0.