Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rb] Disable provide response test for Firefox #15295

Conversation

aguspe
Copy link
Contributor

@aguspe aguspe commented Feb 18, 2025

User description

Motivation and Context

The provide response test is failing on Firefox due to the parameters not being supported, this PR skips that test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix


Description

  • Skipped a failing test for Firefox due to unsupported parameters.

  • Added an exception with a reason for skipping the test.


Changes walkthrough 📝

Relevant files
Bug fix
network_spec.rb
Skip 'provides response' test for Firefox                               

rb/spec/integration/selenium/webdriver/bidi/network_spec.rb

  • Skipped the 'provides response' test for Firefox.
  • Added an exception with a reason for the skip.
  • +2/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 18, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Fix incorrect RSpec test metadata

    Use skip instead of except in RSpec test metadata. The correct RSpec syntax for
    skipping tests is :skip with an optional reason message.

    rb/spec/integration/selenium/webdriver/bidi/network_spec.rb [148-149]

    -it 'provides response', except: {browser: :firefox,
    -                                     reason: 'Provide response parameters are not supported in Firefox'} do
    +it 'provides response', skip: 'Provide response parameters are not supported in Firefox' do
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly identifies that 'except' is not a valid RSpec metadata key for skipping tests. Using 'skip' is the proper RSpec syntax and will ensure the test is correctly marked as skipped with the appropriate reason.

    Medium
    • Update

    @aguspe aguspe changed the title skip test for rubocop [rb] Disable provide response test for Firefox Feb 18, 2025
    @aguspe aguspe added the ruby Pull requests that update Ruby code label Feb 18, 2025
    @aguspe aguspe added C-rb and removed ruby Pull requests that update Ruby code labels Feb 18, 2025
    @VietND96 VietND96 force-pushed the release-preparation-4.29.0 branch 2 times, most recently from e40168e to 9c38306 Compare February 19, 2025 06:59
    @VietND96 VietND96 merged commit 426d091 into SeleniumHQ:release-preparation-4.29.0 Feb 19, 2025
    23 checks passed
    VietND96 added a commit that referenced this pull request Feb 19, 2025
    * Update pinned browser versions
    
    * Update supported versions for Chrome DevTools
    
    * Update selenium manager version
    
    * Update authors file
    
    * FIX CHANGELOGS BEFORE MERGING!
    
    Update versions and change logs to release Selenium 4.29.0
    
    * [create-pull-request] automated change
    
    * Update CHANGELOG cross bindings
    
    * Update CHANGELOG for new upstream changes
    
    * Update CHANGELOG for a new change
    
    * [rb] Disable provide response test for Firefox (#15295)
    
    * [rb] Update rules ruby to latest version and module (#15282)
    
    * [ci] Update setup-bazel v0.13.0
    
    ---------
    
    Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
    Co-authored-by: Selenium CI Bot <selenium-ci@users.noreply.github.com>
    Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
    Co-authored-by: Augustin Gottlieb <33221555+aguspe@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants