-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Disable provide response test for Firefox #15295
[rb] Disable provide response test for Firefox #15295
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
…' into rb_disable_provide_response_test
e40168e
to
9c38306
Compare
426d091
into
SeleniumHQ:release-preparation-4.29.0
* Update pinned browser versions * Update supported versions for Chrome DevTools * Update selenium manager version * Update authors file * FIX CHANGELOGS BEFORE MERGING! Update versions and change logs to release Selenium 4.29.0 * [create-pull-request] automated change * Update CHANGELOG cross bindings * Update CHANGELOG for new upstream changes * Update CHANGELOG for a new change * [rb] Disable provide response test for Firefox (#15295) * [rb] Update rules ruby to latest version and module (#15282) * [ci] Update setup-bazel v0.13.0 --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: Selenium CI Bot <selenium-ci@users.noreply.github.com> Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: Augustin Gottlieb <33221555+aguspe@users.noreply.github.com>
User description
Motivation and Context
The provide response test is failing on Firefox due to the parameters not being supported, this PR skips that test
Types of changes
Checklist
PR Type
Bug fix
Description
Skipped a failing test for Firefox due to unsupported parameters.
Added an exception with a reason for skipping the test.
Changes walkthrough 📝
network_spec.rb
Skip 'provides response' test for Firefox
rb/spec/integration/selenium/webdriver/bidi/network_spec.rb