DeviceRotation implementation #2482
Conversation
|
@lukeis fixed my commits. |
| import java.util.Map; | ||
| import com.google.common.collect.ImmutableMap; | ||
|
|
||
| public class DeviceRotation { |
There was a problem hiding this comment.
This class will be consumed by users, please add JavaDoc to it and all public methods
|
@Rafael-Chavez which email do you want associated to the commit? Also, you're going to need to add an implementation of calling this endpoint in the AddRotatable class. I don't like the way it's implemented there, but you don't need to change that, maybe changing the if/else if to a switch statement instead. |
rafe-g
force-pushed
the
master
branch
5 times, most recently
from
2e3a89c
to
123e0f1
Compare
|
@lukeis updated, please review. |
| } else if ("getOrientation".equals(method.getName())) { | ||
| return ScreenOrientation.valueOf((String) executeMethod.execute( | ||
| DriverCommand.GET_SCREEN_ORIENTATION, null)); | ||
| RotatableMethod m = RotatableMethod.valueOf(method.getName()); |
There was a problem hiding this comment.
you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)
|
updated mobile spec here |
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement