Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation support. #439

Closed
wants to merge 1 commit into from
Closed

Rotation support. #439

wants to merge 1 commit into from

Conversation

rafe-g
Copy link
Contributor

@rafe-g rafe-g commented Jul 16, 2016 •
edited
Loading

Change list

Please provide briefly described change list which are you going to propose.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@rafe-g
Copy link
Contributor Author

rafe-g commented Jul 16, 2016

@TikhomirovSergey

rafe-g
rafe-g reviewed Jul 16, 2016
View reviewed changes
src/main/java/io/appium/java_client/AppiumDriver.java

@Override
public DeviceRotation rotation() {
Response response = execute(DriverCommand.GET_SCREEN_ROTATION);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry let me update this, forgot to commit this part.

@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Jul 16, 2016 •
edited
Loading

Hi @Rafael-Chavez
I have found the PR that you proposed to Selenium
SeleniumHQ/selenium#2474

@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Jul 16, 2016 •
edited
Loading

Ok, Firstly
Could you get fixed the issue which has been found by codecy?

TikhomirovSergey
TikhomirovSergey reviewed Jul 16, 2016
View reviewed changes
pom.xml
<artifactId>selenium-java</artifactId>
<version>2.53.0</version>
<exclusions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this?

@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Jul 16, 2016 •
edited
Loading

It is interesting.
I think it is great to have a feature like that. But there are problems

  • The Selenium Java clint still doesn't contain the DeviceRotation class. Maybe it has sense to add that class to the Appium java clent?
  • are you sure that Appium server supports this command? Please take a look at that string. @imurchie @jlipps Could you clarify what does this command do? If there is no such get/set command then I think it makes sense to implement them on the server side.

ping @SrinivasanTarget

@rafe-g rafe-g force-pushed the master branch 3 times, most recently from e3a034f to c9db0ba Compare July 17, 2016 07:37
rafe-g
rafe-g reviewed Jul 17, 2016
View reviewed changes
src/main/java/io/appium/java_client/AppiumDriver.java

@Override
public DeviceRotation rotation() {
Response response = execute(DriverCommand.GET_SCREEN_ROTATION);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable is being used.

@SrinivasanTarget
Copy link
Member

It's really a cool feature 👍 I see we have this endpoint implemented only in appium-ios-driver here https://github.com/appium/appium-ios-driver/blob/master/lib/commands/gesture.js#L63

@rafe-g
Copy link
Contributor Author

rafe-g commented Jul 18, 2016

@SrinivasanTarget actually the link you pasted is for the endpoint /rotate

the mobile spec defines a /rotation endpoint. Maybe a good idea to merge these two? im not sure what spec this mobileRotation command was adhering to. Maybe @jlipps @imurchie can give more details?

@rafe-g
Copy link
Contributor Author

rafe-g commented Jul 18, 2016

@TikhomirovSergey DeviceRotation class is proposed to be part of selenium project.
SeleniumHQ/selenium#2482

@rafe-g rafe-g force-pushed the master branch 5 times, most recently from b39f2d0 to c38451e Compare July 19, 2016 00:41
@rafe-g
Copy link
Contributor Author

rafe-g commented Jul 19, 2016 •
edited
Loading

@TikhomirovSergey @SrinivasanTarget i updated the routes in the appium server to support this command. The selenium pull request has been merged already.

@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Jul 21, 2016 •
edited
Loading

@Rafael-Chavez Ok. It will be merged when it will be available in selenium. Are you agree?

@rafe-g
Copy link
Contributor Author

rafe-g commented Jul 21, 2016 •
edited
Loading

you mean on the next selenium release?

@TikhomirovSergey
Copy link
Contributor

Yes

@SrinivasanTarget SrinivasanTarget mentioned this pull request Oct 12, 2016
Merged
3 tasks
@SrinivasanTarget
Copy link
Member

Closing this in favor of #489

@SrinivasanTarget SrinivasanTarget mentioned this pull request Nov 17, 2016
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafe-g @TikhomirovSergey @SrinivasanTarget