Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TestRunners for first_script.en.md #1324

Closed
wants to merge 42 commits into from

Conversation

GavinHaydy
Copy link
Contributor

@GavinHaydy GavinHaydy commented Mar 1, 2023

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

add document for firstScript #1298

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

GavinHaydy and others added 30 commits October 17, 2022 09:35
…load.ja.md, file_upload.pt-br.md, file_upload.zh-cn.md
…load.ja.md, file_upload.pt-br.md, file_upload.zh-cn.md
…load.ja.md, file_upload.pt-br.md, file_upload.zh-cn.md
…load.ja.md, file_upload.pt-br.md, file_upload.zh-cn.md
@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 4e9ebd5
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/64196c081e614500082b1eb7
😎 Deploy Preview https://deploy-preview-1324--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @the-ruffian!

I left some comments.

@GavinHaydy GavinHaydy requested a review from diemol March 1, 2023 06:16
@diemol
Copy link
Member

diemol commented Mar 1, 2023

Actually I am going to let @titusfortner check it because he has a better understanding on how this should look like.

@diemol diemol requested a review from titusfortner March 1, 2023 10:03
@titusfortner
Copy link
Member

titusfortner commented Mar 4, 2023

I see that we're getting these to match what JS has, but if a user doesn't already know these things, reading this in the documentation is not going to help them.

I think we actually need to create a separate page for this and create a full tutorial.

Probably the best thing to do in this section right now is to describe why to use a test framework, list options, and then link to what we've done in our examples (https://github.com/SeleniumHQ/seleniumhq.github.io/tree/trunk/examples/)

@GavinHaydy
Copy link
Contributor Author

I see that we're getting these to match what JS has, but if a user doesn't already know these things, reading this in the documentation is not going to help them.

I think we actually need to create a separate page for this and create a full tutorial.

Probably the best thing to do in this section right now is to describe why to use a test framework, list options, and then link to what we've done in our examples (https://github.com/SeleniumHQ/seleniumhq.github.io/tree/trunk/examples/)

That's a good idea. I'll try to do it

@GavinHaydy
Copy link
Contributor Author

@titusfortner Maybe we can create a “Install Unit test framework” between “Install Driver” and "Fires Script" to write the unit test framework and project configuration.

@titusfortner
Copy link
Member

Well, you don't need a test runner to use Selenium if you just want to write a quick script and execute it.

We're trying to support the idea that Selenium is used for more than testing, and that a test framework with a test runner is overkill unless attempting to scale up a testing solution.

"First script" is supposed to be the bare minimum requirements to get Selenium to execute.

But then we point out how testers need to scale up code for a successful testing strategy.

@GavinHaydy
Copy link
Contributor Author

I finished.
Please check it

@GavinHaydy GavinHaydy closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants