Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked icons #2046

Closed
Anachron opened this issue Apr 1, 2015 · 18 comments
Closed

Stacked icons #2046

Anachron opened this issue Apr 1, 2015 · 18 comments
Milestone

Comments

@Anachron
Copy link

Anachron commented Apr 1, 2015

I've just setup this fiddle to demonstrate how that could work out: http://jsfiddle.net/kuajqc0d/6/

This would allow to easily mix icons together.

I've already suggested it here:
FortAwesome/Font-Awesome#1181

@cazzoo
Copy link

cazzoo commented Apr 1, 2015

Wow, really smart implementation. I think It can be easily improved with LESS with main and laternative color for icon and sub/stacked-icon.

@Anachron
Copy link
Author

Anachron commented Apr 1, 2015

It's just a quick&dirty proof-of-concept, just want to collect some feedback. 👍

@Anachron
Copy link
Author

Anachron commented Apr 1, 2015

@cazzoo I'm getting crazy, help me! 💃

http://jsfiddle.net/kuajqc0d/9/

@jlukic
Copy link
Member

jlukic commented Apr 1, 2015

No reason not to include this. Its extremely easy to code and useful. I'll sneak in 2.0

@jlukic jlukic added this to the 2.0 milestone Apr 1, 2015
@Anachron
Copy link
Author

Anachron commented Apr 1, 2015

Thanks @jlukic!

@jlukic
Copy link
Member

jlukic commented Apr 1, 2015

Although these are nice, they probably wont work in a variety of circumstances where icons inherit sizing from other elements like labeled icon menu, icon header etc. I'm not sure how viable that makes them.

@Anachron
Copy link
Author

Anachron commented Apr 1, 2015

You may want to play around with it. You could make it 30% of the "parent icon" and push it to bottom right. This code is just quick&dirty.

@jlukic
Copy link
Member

jlukic commented Apr 1, 2015

Yeah for relative sizing to work, the icon would have to be a child element inside another icon, so we have two scenarios. Sibling stacked icons , which would have similar grouped html as other groups, and sub icons which would be an icon nested inside another icon.

I still need to test some things out.

jlukic added a commit that referenced this issue Apr 1, 2015
@Anachron
Copy link
Author

Anachron commented Apr 2, 2015

@jlukic do you mind posting a jsfiddle example of your implementation?
I want to mess around with it and give you some feedback. (Also test on mobile)

@jlukic
Copy link
Member

jlukic commented Apr 2, 2015

Yeah on mobile now, will do when back at office.

You can find html examples before then in the docs repo under branch next.

@Anachron
Copy link
Author

Anachron commented Apr 2, 2015

@jlukic is there a preview of next somewhere to watch online? Or do I have to build it myself?
(Semantic-Org/Semantic-UI-Docs@b28b48e)

@jlukic
Copy link
Member

jlukic commented Apr 3, 2015

No, but ill make a jsfiddle sorry its been a busy week.

@Anachron
Copy link
Author

Anachron commented Apr 6, 2015

@jlukic how is it going here? :)

@MrFusion42
Copy link

@Anachron you can take the raw build files from the next branch and use them through rawgit.com. With that, you can create a jsfiddle or codepen.io to experiment.

Here's the CDN links to the latest builds in the branch next:

Minified
https://cdn.rawgit.com/Semantic-Org/Semantic-UI/next/dist/semantic.min.css
https://cdn.rawgit.com/Semantic-Org/Semantic-UI/next/dist/semantic.min.js

Non-Minified
https://cdn.rawgit.com/Semantic-Org/Semantic-UI/next/dist/semantic.css
https://cdn.rawgit.com/Semantic-Org/Semantic-UI/next/dist/semantic.js

Kitchen Sink test page
Unfortunately, the kitchensink test page has been moved in the repo so the relative path to semantic.css needs to be edited (easily done through the browser's inspector, just prepend ../).

Here's a patched version of the kitchensink (I just modified the CSS/JS/image paths).

@jlukic
Copy link
Member

jlukic commented Apr 13, 2015

I haven't spent too much time on this, but you can see some examples here
http://beta.semantic-ui.com/elements/icon.html#icon-group

I'm still updating some of the examples so they have moved around temporarily.

But there will be some new examples

@jlukic jlukic modified the milestones: 2.0 RC2, 2.0 Jun 1, 2015
@jlukic
Copy link
Member

jlukic commented Jun 23, 2015

I'm happy enough with the current state of grouped icons

@Anachron If you see any easily correctable issues for launch related to icon groups feel free to let me know.

@jlukic jlukic closed this as completed Jun 23, 2015
@Anachron
Copy link
Author

@jlukic was giving it a go, however, the navigation seems to be broken in next:
http://beta.semantic-ui.com/elements/icon.html#/definition

Clicking on item groups on the sidebar (Groups > icons) actually throws me back to the list of icons (wrong link).

Edit: Other than that, it seems good to go!

@jlukic
Copy link
Member

jlukic commented Jun 24, 2015

yeah, the anchor links dont check to see if they are uniquely named. since they both have the same title its linking back to the first one.

I'll need to have fix it to generate the link as #icon2 or something.. I'll put it on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants