-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stacked icons #2046
Comments
Wow, really smart implementation. I think It can be easily improved with LESS with main and laternative color for icon and sub/stacked-icon. |
It's just a quick&dirty proof-of-concept, just want to collect some feedback. 👍 |
@cazzoo I'm getting crazy, help me! 💃 |
No reason not to include this. Its extremely easy to code and useful. I'll sneak in 2.0 |
Thanks @jlukic! |
Although these are nice, they probably wont work in a variety of circumstances where icons inherit sizing from other elements like |
You may want to play around with it. You could make it 30% of the "parent icon" and push it to bottom right. This code is just quick&dirty. |
Yeah for relative sizing to work, the icon would have to be a child element inside another icon, so we have two scenarios. Sibling stacked icons , which would have similar grouped html as other groups, and I still need to test some things out. |
@jlukic do you mind posting a jsfiddle example of your implementation? |
Yeah on mobile now, will do when back at office. You can find html examples before then in the docs repo under branch next. |
@jlukic is there a preview of next somewhere to watch online? Or do I have to build it myself? |
No, but ill make a jsfiddle sorry its been a busy week. |
@jlukic how is it going here? :) |
@Anachron you can take the raw build files from the Here's the CDN links to the latest builds in the branch Minified Non-Minified Kitchen Sink test page Here's a patched version of the kitchensink (I just modified the CSS/JS/image paths). |
I haven't spent too much time on this, but you can see some examples here I'm still updating some of the examples so they have moved around temporarily. But there will be some new examples |
I'm happy enough with the current state of grouped icons @Anachron If you see any easily correctable issues for launch related to icon groups feel free to let me know. |
@jlukic was giving it a go, however, the navigation seems to be broken in next: Clicking on item groups on the sidebar (Groups > icons) actually throws me back to the list of icons (wrong link). Edit: Other than that, it seems good to go! |
yeah, the anchor links dont check to see if they are uniquely named. since they both have the same title its linking back to the first one. I'll need to have fix it to generate the link as |
I've just setup this fiddle to demonstrate how that could work out: http://jsfiddle.net/kuajqc0d/6/
This would allow to easily mix icons together.
I've already suggested it here:
FortAwesome/Font-Awesome#1181
The text was updated successfully, but these errors were encountered: