Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] Fix icons alignment #229

Merged
merged 1 commit into from
Nov 2, 2018
Merged

[Icon] Fix icons alignment #229

merged 1 commit into from
Nov 2, 2018

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Oct 30, 2018 •
edited
Loading

Description

Remove uncessesary margin so 2 icon in .icons looks center-aligned.

I suppose the margin-right is not much needed, from the commit histories.

b21a566 | Thu Apr 02 08:23:23 JST 2015 | jlukic | Semantic-Org/Semantic-UI#2046 First pass of grouped icons

It seems just follows i.icon definition.

i.icon {
  display: inline-block;
  opacity: @opacity;
  margin: 0em @distanceFromText 0em 0em;

Testcase

http://jsfiddle.net/z2yLmw67/5/

Screenshot (when possible)

Before

inner/corner icons are slightly right-aligned
before

After:

after

Closes

Semantic-Org/Semantic-UI#5861

@lubber-de lubber-de added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI type/feat Any feature requests or improvements labels Oct 30, 2018
y0hami
y0hami approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lubber-de
lubber-de approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ColinFrick
ColinFrick approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Nov 2, 2018
@y0hami y0hami merged commit 91ea667 into fomantic:beta Nov 2, 2018
@lubber-de
Copy link
Member

This also fixes
Semantic-Org/Semantic-UI#6466

@lubber-de lubber-de added this to the 2.6.4 milestone Nov 5, 2018
@y0hami y0hami mentioned this pull request Nov 14, 2018
Merged
@exoego exoego deleted the icons-alignment branch January 3, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@y0hami y0hami y0hami approved these changes

@prudho prudho prudho approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@exoego @lubber-de @ColinFrick @prudho @y0hami