-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/2.6.4 release #247
Merged
Merged
chore/2.6.4 release #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old generic fix to completely hide a hidden placeholder was disturbing popup position calculations, because offsets for popups now always resulted in top:0,left:0. This PR reverts #148 and fixes it again directly in placeholder definition As a side effect the popup position calculations are working as before 2.6.3 again Closes #148, #240
Introduced by #189
This was referenced Nov 14, 2018
lubber-de
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ColinFrick
approved these changes
Nov 14, 2018
prudho
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.6.4 - November 15, 2018
Enhancements
Bugs
showOnFocus: false
preventing click to open dropdown Thanks @lubber-de #193simple dropdown
preventing submenu items from being clicked Thanks @lubber-de #203clearable
Thanks @lubber-de #244data-value
Thanks @lubber-de #224