-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dimmer] Added support for using dimmers only partially on top,center,bottom #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just me or center caption dimmer
looks blurred compared to others ?
@prudho Thanks..., that's the old nasty webkit bug. Fixed by latest commit. |
I'm conflicted with naming this |
I am totally open to this. 🙂 @prudho @hammy2899 Your opinion? |
|
IMHO I think |
@hammy2899 is the most english of us 😄, so i'll follow his advice. |
Then i am going to change it to "partially center" instead of "center partially" @hammy2899 Agreed? |
We could also completely omit partially but simply use |
Removed the need for any additional className. Much cleaner. I don't know why i haven't done it this way right from the start 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Docs here |
Description
This adds the possibility to use any dimmer only partially and limited only to the overall height of its content and not over the whole to be covered area. This can be used for example as a caption on any element of choice by simply using
top dimmer
,center dimmer
orbottom dimmer
Works also very well with transitions 'fade up' or 'fade down'
Testcase
Static without Javascript (just add
active
to the dimmer as usual)Animation triggered via Javascript
Screenshot
Closes
Semantic-Org/Semantic-UI#3459
Semantic-Org/Semantic-UI#6621