Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popup] Add no javascript popup some new features #202

Merged
merged 3 commits into from
Nov 11, 2018
Merged

[Popup] Add no javascript popup some new features #202

merged 3 commits into from
Nov 11, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Oct 24, 2018

Description

This PR adds two features for the no javascript version of popup, a.k.a. tooltip:

  • Size variation
    331634b51b3efebec7c382ed72f12867.gif

  • Basic variation
    78bc68a29ad34dc69b19dcff138be3d5.gif

Bonus point ! These features can be used together:

<button class="ui primary icon button" data-variation="tiny basic" data-inverted="" data-tooltip="I am a tiny inverted basic tooltip !">
  <i class="plus icon"></i>
</button>

Will display:
235ab06ba737fff6ed8c24cad2a8b15a.png

@prudho prudho added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Oct 24, 2018
@prudho prudho added this to the 2.6.4 milestone Oct 24, 2018
@prudho prudho self-assigned this Oct 24, 2018
lubber-de
lubber-de approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
LGTM

@y0hami
Copy link
Member

y0hami commented Oct 24, 2018

I want to put this on hold and test something because I might have a better approach to this.

@y0hami y0hami added the state/on-hold Issues and pull requests which are on hold for any reason label Oct 24, 2018
y0hami
y0hami approved these changes Nov 11, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed state/awaiting-reviews Pull requests which are waiting for reviews state/on-hold Issues and pull requests which are on hold for any reason labels Nov 11, 2018
@y0hami y0hami merged commit c284ecd into fomantic:beta Nov 11, 2018
@lubber-de lubber-de mentioned this pull request Nov 12, 2018
Merged
@y0hami y0hami added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Nov 12, 2018
@y0hami y0hami mentioned this pull request Nov 14, 2018
Merged
@prudho prudho deleted the popup-nojs-enhancements branch April 11, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees

@prudho prudho

Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@prudho @y0hami @lubber-de