Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] Prevent user selection #246

Merged
merged 1 commit into from
Nov 12, 2018
Merged

[Dropdown] Prevent user selection #246

merged 1 commit into from
Nov 12, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Nov 11, 2018 •
edited
Loading

Description

This PR prevents user selection of whole dropdown (as it is done in mostly all other components aswell)
I especially tested this, because i had doubts it might block the search or filter input fields. And they still work fine. 👍
Infact, for every button dropdown this was already implemented, because button sets user-select:none by default since ages 🙂

Original PR by @chaaya

Testcase

https://fomantic-ui.com/modules/dropdown.html

  • Search Dropdown & Search In-Menu Dropdown already have this applied (cannot mark by mouse, because they are button)
  • 2nd Search In-Menu is not a button, so you can currently mark everything of it by the mouse

Screenshot

dropdown_user_select

Closes

Semantic-Org/Semantic-UI#6629

@lubber-de lubber-de self-assigned this Nov 11, 2018
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Nov 11, 2018
y0hami
y0hami approved these changes Nov 11, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Nov 12, 2018
@y0hami y0hami merged commit 40374b8 into fomantic:beta Nov 12, 2018
@lubber-de lubber-de deleted the fix/6629/disable_dropdown_text_selection branch November 12, 2018 09:00
@y0hami y0hami mentioned this pull request Nov 14, 2018
Merged
@lubber-de lubber-de added this to the 2.6.4 milestone Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@prudho prudho prudho approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees

@lubber-de lubber-de

Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @prudho @y0hami