Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Prevent close/open bubbling on keyselect via enter #190

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Oct 22, 2018

Description

Since implementing #143, whenever one selected an item on multiple search via enter, the DropDown-List was closing/opening immediatly making it look ugly.
This PR fixes that. It simply does not hide the List on multiple anymore.

Screenshot

Before:
multidd_after

After:
multidd_after_fixed_bubbling

Closes

#143

@lubber-de lubber-de added lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 22, 2018
@lubber-de lubber-de changed the title [Dropdown] Prevent close/open bubbling von keyselect via enter [Dropdown] Prevent close/open bubbling on keyselect via enter Oct 22, 2018
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami added type/bug Any issue which is a bug or PR which fixes a bug and removed state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 24, 2018
@y0hami y0hami merged commit 6ed8db1 into fomantic:beta Oct 24, 2018
@lubber-de lubber-de deleted the dropdown_keysearch_menububbling branch October 24, 2018 07:32
@lubber-de lubber-de added this to the 2.6.4 milestone Nov 5, 2018
lubber-de added a commit to lubber-de/Fomantic-UI that referenced this pull request Nov 10, 2018
lubber-de added a commit to lubber-de/Fomantic-UI that referenced this pull request Nov 10, 2018
@y0hami y0hami mentioned this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants